Fix performance regression in incremental builds#5439
Merged
snowleopard merged 1 commit intoocaml:mainfrom Feb 16, 2022
Merged
Conversation
rgrinberg
approved these changes
Feb 16, 2022
Member
rgrinberg
left a comment
There was a problem hiding this comment.
The regression is pretty severe, so I wonder if it's worth including the fix in Dune 3.0 (if there is still time).
We don't pull releases anymore, but I can publish 3.0.1 with this fix (+ others).
184851e to
c2d42da
Compare
Signed-off-by: Andrey Mokhov <amokhov@janestreet.com>
c2d42da to
0b0093c
Compare
Merged
rgrinberg
added a commit
to rgrinberg/opam-repository
that referenced
this pull request
Feb 17, 2022
…e-rpc, dune-rpc-lwt, dune-private-libs, dune-glob, dune-configurator, dune-build-info and dune-action-plugin (3.0.1) CHANGES: - Fix compilation on MacOS SDK < 10.13. The native watch mode is disabled in such instances (ocaml/dune#5431 fix ocaml/dune#5430, @rgrinberg) - Do no add workspace_root to `BUILD_PATH_PREFIX_MAP` for projects before 3.0 (5448, @rgrinberg) - Fix performance regression in incremental builds (ocaml/dune#5439, @snowleopard)
dra27
pushed a commit
to dra27/dune
that referenced
this pull request
Mar 10, 2022
Signed-off-by: Andrey Mokhov <amokhov@janestreet.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@rgrinberg This is a tiny change, please have a look soon.
The regression is pretty severe, so I wonder if it's worth including the fix in Dune 3.0 (if there is still time).