Add [Needs_stack_trace] annotation for user errors#5047
Merged
snowleopard merged 1 commit intoocaml:mainfrom Oct 25, 2021
Merged
Add [Needs_stack_trace] annotation for user errors#5047snowleopard merged 1 commit intoocaml:mainfrom
snowleopard merged 1 commit intoocaml:mainfrom
Conversation
CallumMoseley
approved these changes
Oct 25, 2021
Signed-off-by: Andrey Mokhov <amokhov@janestreet.com>
6c72d89 to
b1f7061
Compare
snowleopard
added a commit
that referenced
this pull request
Nov 2, 2021
Thanks to #5075 and #5047, we can now easily provide more information for some library resolution errors. I think it's pretty helpful to tell the user why the problematic library was required. In fact, in one of the tests, this was suggested as a future improvement. We could only do this for a subset of errors in this module, but after studying the new error messages, I think all of them got better. Signed-off-by: Andrey Mokhov <amokhov@janestreet.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #5025 that introduces directory targets, I need a way to force a user error to include the stack trace even though it has an embedded location.
This PR makes this possible via the new
Needs_stack_traceannotation. I also fix a naming inconsistency and renamehas_embed_locationtohas_embedded_location.