Drop remaining references to visibility in Memo#4542
Merged
snowleopard merged 3 commits intoocaml:mainfrom Apr 28, 2021
Merged
Conversation
Signed-off-by: Andrey Mokhov <amokhov@janestreet.com>
Signed-off-by: Andrey Mokhov <amokhov@janestreet.com>
6f5492a to
8df9345
Compare
aalekseyev
reviewed
Apr 28, 2021
Signed-off-by: Andrey Mokhov <amokhov@janestreet.com>
21260c1 to
cd83cfe
Compare
|
Nice! BTW, the |
Collaborator
Author
|
@jeremiedimino Indeed! I hesitated deleting them because I thought we might need them for debugging, but perhaps we should just get rid of them. |
|
Personally, I think we should get rid of them. I've found the memo stack dumps useful in the past, so |
Collaborator
|
Agreed, I also never needed that. |
Collaborator
Author
|
Sounds good, I'll remove them then! |
snowleopard
added a commit
that referenced
this pull request
May 3, 2021
As discussed in #4542, we are removing the requirement to provide [to_dyn] for outputs of memoized functions. This helps us to simplify the API and get rid of some internal complexity. Signed-off-by: Andrey Mokhov <amokhov@janestreet.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that #4540 left
create_hiddenwhose name is now out of date.I initially wanted to rename it to
create_simplebut after discussing with @aalekseyev, we thought that it would be better to renameOutput.SimpletoOutput.Cutoffandcreate_hiddentocreate_no_cutofffor greater clarity at call sites.While doing the renaming, I noticed that in a few places we can simplify the code by using
create_no_cutoffinstead ofcreate, which doesn't require to pass theOutputmodule, which was often created on the spot.