cram directory tests: skip empty directories#3753
Merged
emillon merged 2 commits intoocaml:masterfrom Sep 2, 2020
Merged
Conversation
53c7eef to
879dd0f
Compare
rgrinberg
approved these changes
Sep 1, 2020
Member
rgrinberg
left a comment
There was a problem hiding this comment.
Looks ok. Another option is to make this a warning.
PS we need a CHANGES entry
879dd0f to
e76a357
Compare
Collaborator
Author
|
cool, thanks. Also, I noticed that there are no tests for this. I'll try to test that in a cram test itself. |
Collaborator
Author
|
Done. That was a bit weird due to |
In the case of cram directory tests (directories with a name that ends in .t), there's a check that they contain a `run.t` file. When that is not the case, the build errors out. It can cause problems because empty directories are not tracked by git. An update can leave empty directories behind, which can make builds fail in a mysterious way. This relaxes the existing check by skipping empty directories. Signed-off-by: Etienne Millon <me@emillon.org>
Signed-off-by: Etienne Millon <me@emillon.org>
9f987be to
0c6c7ca
Compare
rgrinberg
added a commit
to rgrinberg/opam-repository
that referenced
this pull request
Sep 3, 2020
…lugin, dune-private-libs and dune-glob (2.7.1) CHANGES: - configurator: More flexible probing of `#define`. We allow duplicate values in the object file, as long as they are the same after parsing. (ocaml/dune#3739, fixes ocaml/dune#3736, @rgrinberg) - Record instrumentation backends in dune-package files. This makes it possible to use instrumentation backends defined in installed libraries (eg via OPAM). (ocaml/dune#3735, @nojb) - Add missing `.aux` & `.glob` targets to coq rules (ocaml/dune#3721, fixes ocaml/dune#3437, @rgrinberg) - Fix `dune-package` installation when META templates are present (ocaml/dune#3743, fixes ocaml/dune#3746, @rgrinberg) - Resolve symlinks before running `$ git diff` (ocaml/dune#3750, fixes ocaml/dune#3740, @rgrinberg) - Cram tests: when checking that all test directories contain a `run.t` file, skip empty directories. These can be left around by git. (ocaml/dune#3753, @emillon)
rgrinberg
added a commit
to rgrinberg/opam-repository
that referenced
this pull request
Sep 5, 2020
…lugin, dune-private-libs and dune-glob (2.7.1) CHANGES: - configurator: More flexible probing of `#define`. We allow duplicate values in the object file, as long as they are the same after parsing. (ocaml/dune#3739, fixes ocaml/dune#3736, @rgrinberg) - Record instrumentation backends in dune-package files. This makes it possible to use instrumentation backends defined in installed libraries (eg via OPAM). (ocaml/dune#3735, @nojb) - Add missing `.aux` & `.glob` targets to coq rules (ocaml/dune#3721, fixes ocaml/dune#3437, @rgrinberg) - Fix `dune-package` installation when META templates are present (ocaml/dune#3743, fixes ocaml/dune#3746, @rgrinberg) - Resolve symlinks before running `$ git diff` (ocaml/dune#3750, fixes ocaml/dune#3740, @rgrinberg) - Cram tests: when checking that all test directories contain a `run.t` file, skip empty directories. These can be left around by git. (ocaml/dune#3753, @emillon)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the case of cram directory tests (directories with a name that ends in .t), there's a check that they contain a
run.tfile. When that is not the case, the build errors out.It can cause problems because empty directories are not tracked by git. An update can leave empty directories behind, which can make builds fail in a mysterious way.
This relaxes the existing check by skipping empty directories.