Skip to content

Fix version contstraint for artifact variables#3149

Merged
nojb merged 2 commits intoocaml:masterfrom
nojb:fix_artifact_var_version
Feb 17, 2020
Merged

Fix version contstraint for artifact variables#3149
nojb merged 2 commits intoocaml:masterfrom
nojb:fix_artifact_var_version

Conversation

@nojb
Copy link
Copy Markdown
Collaborator

@nojb nojb commented Feb 17, 2020

These were introduced in 2.0.

Signed-off-by: Nicolás Ojeda Bär <n.oje.bar@gmail.com>
@rgrinberg
Copy link
Copy Markdown
Member

Good catch. This is a bug fix I suppose, so let's add it to the changes.

Signed-off-by: Nicolás Ojeda Bär <n.oje.bar@gmail.com>
@nojb
Copy link
Copy Markdown
Collaborator Author

nojb commented Feb 17, 2020

Good catch. This is a bug fix I suppose, so let's add it to the changes.

Done. The issue was reported by @pascutto.

@nojb nojb merged commit 859bd98 into ocaml:master Feb 17, 2020
@nojb nojb deleted the fix_artifact_var_version branch February 17, 2020 13:47
rgrinberg added a commit to rgrinberg/opam-repository that referenced this pull request Feb 20, 2020
…lugin, dune-private-libs and dune-glob (2.3.1)

CHANGES:

- Fix versioning of artifact variables (eg %{cmxa:...}), which were introduced
  in 2.0, not 1.11. (ocaml/dune#3149, @nojb)

- Fix a bug introduced in 2.3.0 where dune insists on using `fswatch` on linux
  (even when `inotifywait` is available). (ocaml/dune#3162, @aalekseyev)

- Fix a bug causing all executables to be considered as optional (ocaml/dune#3163, @diml)
rgrinberg added a commit to rgrinberg/opam-repository that referenced this pull request Feb 22, 2020
…lugin, dune-private-libs and dune-glob (2.3.1)

CHANGES:

- Fix versioning of artifact variables (eg %{cmxa:...}), which were introduced
  in 2.0, not 1.11. (ocaml/dune#3149, @nojb)

- Fix a bug introduced in 2.3.0 where dune insists on using `fswatch` on linux
  (even when `inotifywait` is available). (ocaml/dune#3162, @aalekseyev)

- Fix a bug causing all executables to be considered as optional (ocaml/dune#3163, @diml)
rgrinberg added a commit to rgrinberg/opam-repository that referenced this pull request Feb 23, 2020
…lugin, dune-private-libs and dune-glob (2.3.1)

CHANGES:

- Fix versioning of artifact variables (eg %{cmxa:...}), which were introduced
  in 2.0, not 1.11. (ocaml/dune#3149, @nojb)

- Fix a bug introduced in 2.3.0 where dune insists on using `fswatch` on linux
  (even when `inotifywait` is available). (ocaml/dune#3162, @aalekseyev)

- Fix a bug causing all executables to be considered as optional (ocaml/dune#3163, @diml)
rgrinberg added a commit to rgrinberg/opam-repository that referenced this pull request Feb 24, 2020
…lugin, dune-private-libs and dune-glob (2.3.1)

CHANGES:

- Fix versioning of artifact variables (eg %{cmxa:...}), which were introduced
  in 2.0, not 1.11. (ocaml/dune#3149, @nojb)

- Fix a bug introduced in 2.3.0 where dune insists on using `fswatch` on linux
  (even when `inotifywait` is available). (ocaml/dune#3162, @aalekseyev)

- Fix a bug causing all executables to be considered as optional (ocaml/dune#3163, @diml)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants