ocamlformat: depend on config files in _build#2471
Merged
aalekseyev merged 4 commits intoocaml:masterfrom Jul 30, 2019
Merged
Conversation
Signed-off-by: Nicolás Ojeda Bär <n.oje.bar@gmail.com>
Signed-off-by: Nicolás Ojeda Bär <n.oje.bar@gmail.com>
Collaborator
Author
|
I added a second (unrelated) commit that registers the dependency on the |
Collaborator
|
This also fixes an assertion failure when running with e.g. |
Collaborator
Author
|
Thanks! |
rgrinberg
added a commit
to rgrinberg/opam-repository
that referenced
this pull request
Aug 9, 2019
CHANGES: - Fix config file dependencies of ocamlformat (ocaml/dune#2471, fixes ocaml/dune#2646, @nojb) - Cleanup stale directories when using `(source_tree ...)` in the presence of directories with only sub-directories and no files (ocaml/dune#2514, fixes ocaml/dune#2499, @diml)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2464. The bug was present before #2404, but hidden by the use of the
--nameoption toocamlformat.