Skip to content

fix(time): address warning on Windows in time_stubs.c#13914

Merged
Alizter merged 1 commit intoocaml:mainfrom
Alizter:push-wmrqtxnszwxk
Mar 25, 2026
Merged

fix(time): address warning on Windows in time_stubs.c#13914
Alizter merged 1 commit intoocaml:mainfrom
Alizter:push-wmrqtxnszwxk

Conversation

@Alizter
Copy link
Copy Markdown
Collaborator

@Alizter Alizter commented Mar 25, 2026 •
edited
Loading

GetProcAddress returns FARPROC and therefore needs an explicit cast. This fixes the warning introduced in #13905.

@Alizter
fix(time): address warning on Windows in time_stubs.c
3a3878a 
Signed-off-by: Ali Caglayan <alizter@gmail.com>
@Alizter Alizter requested a review from nojb March 25, 2026 12:37
This was referenced Mar 25, 2026
Merged
Open
nojb
nojb approved these changes Mar 25, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@nojb nojb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Alizter Alizter merged commit d2120ac into ocaml:main Mar 25, 2026
29 checks passed
@Alizter Alizter deleted the push-wmrqtxnszwxk branch March 25, 2026 12:57
shonfeder pushed a commit that referenced this pull request Mar 27, 2026
@Alizter @shonfeder
fix(time): address warning on Windows in time_stubs.c (#13914)
bb5d106 
`GetProcAddress` returns `FARPROC` and therefore needs an explicit cast.
This fixes the warning introduced in
#13905.

(cherry picked from commit d2120ac)
Signed-off-by: Shon Feder <shon.feder@gmail.com>
shonfeder pushed a commit that referenced this pull request Mar 27, 2026
@Alizter @shonfeder
fix(time): address warning on Windows in time_stubs.c (#13914)
1bd0f1f 
`GetProcAddress` returns `FARPROC` and therefore needs an explicit cast.
This fixes the warning introduced in
#13905.

(cherry picked from commit d2120ac)
Signed-off-by: Shon Feder <shon.feder@gmail.com>
@shonfeder shonfeder mentioned this pull request Mar 27, 2026
Merged
shonfeder added a commit that referenced this pull request Mar 27, 2026
@shonfeder
[3.22.1] backport #13914 (#13946)
4b4e88b 
Backport #13914 onto 3.22.1-rc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nojb nojb nojb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Alizter @nojb