fix(module_trie): allow setting nested path#13103
Merged
anmonteiro merged 1 commit intoocaml:mainfrom Dec 29, 2025
Merged
Conversation
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
Collaborator
|
Would it be worth setting up some unit tests for tries? |
rgrinberg
reviewed
Dec 29, 2025
This was referenced Dec 29, 2025
rgrinberg
approved these changes
Dec 29, 2025
anmonteiro
added a commit
that referenced
this pull request
Dec 30, 2025
depends on #13100 and #13103 ### Summary: - `Ml_sources` now indexes the `ocamllex` stanzas and deduces the targets based on that - Dune records the modules that are generated by `ocamllex` such that we can query their source information when generating corresponding rules. Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
previously:
Module_trie.set Module_trie.empty ["a"; "b"] xwould be silently ignored