Merged
Conversation
f682e7d to
74237d2
Compare
In preparation for improving [available] This also some removes some unnecessary linear searches. We already have a map, so that should never be needed. Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
74237d2 to
5cd82f2
Compare
Alizter
approved these changes
Dec 8, 2025
davesnx
pushed a commit
to davesnx/dune
that referenced
this pull request
Dec 8, 2025
* dev Signed-off-by: Rudi Grinberg <me@rgrinberg.com> * refactor: make [Only_package.t] abstract In preparation for improving [available] This also some removes some unnecessary linear searches. We already have a map, so that should never be needed. Signed-off-by: Rudi Grinberg <me@rgrinberg.com> --------- Signed-off-by: Rudi Grinberg <me@rgrinberg.com> Signed-off-by: David Sancho Moreno <dsnxmoreno@gmail.com>
davesnx
added a commit
to davesnx/dune
that referenced
this pull request
Dec 8, 2025
…without-system * 'main' of github.com:/ocaml/dune: Move trace events to dune_trace (ocaml#12867) Findlib DB: use id instead of physical equality (ocaml#12877) Make Only_packages.t abstract (ocaml#12882) ocaml-index: delay module iteration into action builder (ocaml#12886) blake3: disable useless warning on ARM (ocaml#12888) Add test for output when locking in multiple ways Always log solution into build log Write the chosen solution to the log
davesnx
pushed a commit
to davesnx/dune
that referenced
this pull request
Dec 10, 2025
* dev Signed-off-by: Rudi Grinberg <me@rgrinberg.com> * refactor: make [Only_package.t] abstract In preparation for improving [available] This also some removes some unnecessary linear searches. We already have a map, so that should never be needed. Signed-off-by: Rudi Grinberg <me@rgrinberg.com> --------- Signed-off-by: Rudi Grinberg <me@rgrinberg.com> Signed-off-by: David Sancho Moreno <dsnxmoreno@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation for improving [available]
This also some removes some unnecessary linear searches. We already have
a map, so that should never be needed.