Fix difference between bootstrap & dune behaviour w.r.t include-subdirs ambiguity#12607
Merged
shonfeder merged 1 commit intoocaml:mainfrom Oct 22, 2025
Merged
Fix difference between bootstrap & dune behaviour w.r.t include-subdirs ambiguity#12607shonfeder merged 1 commit intoocaml:mainfrom
shonfeder merged 1 commit intoocaml:mainfrom
Conversation
…rs ambiguity Signed-off-by: Ali Caglayan <alizter@gmail.com>
0e4a4ba to
f31e973
Compare
Member
|
By "reviewed properly" does it just mean having a review by @anmonteiro ? Asking because the other PR was reviewed by 2, and got an approval, and no defect seems to be reported here, so I'm not sure if something else is missing. |
Collaborator
Author
|
Yes, @rgrinberg requested that @anmonteiro also took a look. |
anmonteiro
approved these changes
Oct 22, 2025
Member
|
Thanks for the review @anmonteiro ! |
davesnx
added a commit
to davesnx/dune
that referenced
this pull request
Oct 22, 2025
…without-system * 'main' of github.com:/ocaml/dune: (33 commits) Fix difference between bootstrap & dune behaviour w.r.t include-subdirs ambiguity (ocaml#12607) Revert "Fix difference between bootstrap & dune behaviour w.r.t include-subdirs ambiguity" fix(include-subdirs-qualified): prefer closer module of the same name Add 2 tests showing difference between bootstrap & dune w.r.t include-subdirs dune init: use source path (ocaml#12601) chore(deps): bump actions/setup-node from 5 to 6 test(melange): show melange compilation isn't part of `@all` alias (ocaml#12603) Disable flaky test (ocaml#12600) Rename path to dir in dune_init (ocaml#12599) Dune project: remove dead code (ocaml#12598) Dune_project refactor (ocaml#12597) doc(melange): reference `dirs` stanza (ocaml#12596) Stanza simplifications (ocaml#12595) Reduce stanza definition boilerplate (ocaml#12592) Rename Stanza_common to Stanza_pkg (ocaml#12593) Remove copied code between library and library_parameter stanzas (ocaml#12594) Split modules settings (ocaml#12591) Move the (include_subdirs qualified) check to a single place (ocaml#12590) refactor: simplify loc/ocamllex/ocamlyacc stanza handling (ocaml#12589) pkg: Implement a package search command ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR #12587 was reverted in #12606. This reverts it again so that it can be reviewed properly.