test: fix exec-watch-server test and demonstrate issue#12361
Merged
Alizter merged 1 commit intoocaml:mainfrom Sep 13, 2025
Merged
test: fix exec-watch-server test and demonstrate issue#12361Alizter merged 1 commit intoocaml:mainfrom
Alizter merged 1 commit intoocaml:mainfrom
Conversation
c32f6b0 to
d79171b
Compare
2 tasks
115c4da to
8410ce1
Compare
rgrinberg
approved these changes
Sep 13, 2025
The timeout set in this test was way too high. I set it back to a sensible level so that when it fails it doesn't stall. I've also added a timeout to the exec-watch tests in general, since there shouldn't be any slow tests. The exec-watch-server test has been reenabled and the issue in ocaml#12323 is demonstrated. Signed-off-by: Ali Caglayan <alizter@gmail.com>
8410ce1 to
dced6aa
Compare
Alizter
added a commit
that referenced
this pull request
Feb 6, 2026
We add a way of tracking whether a job is a process group leader to the scheduler. This allows us to avoid sending a signal to a process group when it isn't needed. Doing so fixes an issue with dune exec -w where rebuilds would send a kill signal to a non-existant process group assumed to be attached to the process we were execing. - [x] depends on #12361 - [x] changelog - fixes #12323
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sleep time set in this test was way too high. I set it back to a sensible level so that when it fails it doesn't stall. I've also added a timeout to the exec-watch tests in general, since there shouldn't be any slow tests.
The exec-watch-server test has been re-enabled and the issue in #12323 is demonstrated.