Merged
Conversation
91f1f54 to
6fb04db
Compare
Alizter
approved these changes
Jul 20, 2025
Collaborator
Alizter
left a comment
There was a problem hiding this comment.
Seems ok. This addresses the TODO on line 759 by the way.
6fb04db to
1cf9d51
Compare
[$ git archive] does not respect submodules. Therefore we need to run it for every submodule ourselves. Signed-off-by: Rudi Grinberg <me@rgrinberg.com> <!-- ps-id: 2f35fda7-d9da-43e3-86a3-2eeb003e7a9c --> Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
Sudha247
pushed a commit
to Sudha247/dune
that referenced
this pull request
Jul 23, 2025
[$ git archive] does not respect submodules. Therefore we need to run it for every submodule ourselves. Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
Leonidas-from-XIV
added a commit
that referenced
this pull request
Dec 23, 2025
While going through the tests looking at the usages of `sed` I noticed that this test works now (fixed in #12046) so I've updated the wording and removed `sed`. Signed-off-by: Marek Kubica <marek@tarides.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[$ git archive] does not respect submodules. Therefore we need to run it for every submodule ourselves.
Fixes #11606