Shorter path for inline-tests by hhugo · Pull Request #11307 · ocaml/dune

hhugo · 2025-01-16T10:25:17Z

The PR uses shorter path names for inline-tests.
I believe there is little value repeating the libname information in the path under .<LIBNAME>.inline-tests

With this PR

_build/default/compiler/tests-jsoo/.jsoo_testsuite_parsing.inline-tests/inline_test_runner_jsoo_testsuite_parsing.bc.wasm.assets/dune__exe__Inline_test_runner_jsoo_testsuite_parsing-2efd143a.wasm.map

becomes

_build/default/compiler/tests-jsoo/.jsoo_testsuite_parsing.inline-tests/run.bc.wasm.assets/dune__exe__Run-65ca7159.wasm.map

and

_build/default/compiler/tests-jsoo/.jsoo_testsuite_parsing.inline-tests/.jsoo_testsuite_parsing.inline-tests.eobjs/jsoo/dune__exe__Inline_test_runner_jsoo_testsuite_parsing.wasmo

becomes

_build/default/compiler/tests-jsoo/.jsoo_testsuite_parsing.inline-tests/.run.eobjs/jsoo/dune__exe__Run.wasmo

hhugo · 2025-01-16T13:50:34Z

This PR fixes all long path related issue in ocsigen/js_of_ocaml#1799

nojb

LGTM

src/dune_rules/inline_tests.ml

nojb · 2025-01-21T07:23:42Z

test/blackbox-tests/test-cases/inline_tests/parallel.t/run.t

-  inline_test_runner_test_lib2 alias test2/runtest
+           run alias test2/runtest
+           run alias test2/runtest
+           run alias test2/runtest


One could argue that the new output is less informative than the old one, but I don't see how we can do better while keeping the paths short.

I've pushed alternative names. the inline-test executable in now called inline-test-runner. Its entry point is main.ml

Thanks. I'm a bit hesitatnt to merge because I have never used inline tests myself so I am not 100% sure I am not missing any details. A quick glance from someone familiar with this part of the code (or @rgrinberg) would be good.

hhugo · 2025-01-27T08:54:01Z

The second commits changes names a bit and avoid duplication between inline_tests.ml and dir_status.ml.

Signed-off-by: Hugo Heuzard <hugo.heuzard@gmail.com>

hhugo · 2025-02-07T12:57:26Z

@rgrinberg, I'd like to make progress with this PR. @nojb suggested you might be able to review it ..

Signed-off-by: Rudi Grinberg <me@rgrinberg.com>

@Sylvain78

CHANGES: ### Fixed - Support HaikuOS: don't call `execve` since it's not allowed if other pthreads have been created. The fact that Haiku can't call `execve` from other threads than the principal thread of a process (a team in haiku jargon), is a discrepancy to POSIX and hence there is a [bug about it](https://dev.haiku-os.org/ticket/18665). (@Sylvain78, ocaml/dune#10953) - Fix flag ordering in generated Merlin configurations (ocaml/dune#11503, @voodoos, fixes ocaml/merlin#1900, reported by @vouillon) ### Added - Add `(format-dune-file <src> <dst>)` action. It provides a replacement to `dune format-dune-file` command. (ocaml/dune#11166, @nojb) - Allow the `--prefix` flag when configuring dune with `ocaml configure.ml`. This allows to set the prefix just like `$ dune install --prefix`. (ocaml/dune#11172, @rgrinberg) - Allow arguments starting with `+` in preprocessing definitions (starting with `(lang dune 3.18)`). (@amonteiro, ocaml/dune#11234) - Support for opam `(maintenance_intent ...)` in dune-project (ocaml/dune#11274, @art-w) - Validate opam `maintenance_intent` (ocaml/dune#11308, @art-w) - Support `not` in package dependencies constraints (ocaml/dune#11404, @art-w, reported by @hannesm) ### Changed - Warn when failing to discover root due to reads failing. The previous behavior was to abort. (@KoviRobi, ocaml/dune#11173) - Use shorter path for inline-tests artifacts. (@hhugo, ocaml/dune#11307) - Allow dash in `dune init` project name (ocaml/dune#11402, @art-w, reported by @saroupille) - On Windows, under heavy load, file delete operations can sometimes fail due to AV programs, etc. Guard against it by retrying the operation up to 30x with a 1s waiting gap (ocaml/dune#11437, fixes ocaml/dune#11425, @MSoegtropIMC) - Cache: we now only store the executable permission bit for files (ocaml/dune#11541, fixes ocaml/dune#11533, @ElectreAAS) - Display negative error codes on Windows in hex which is the more customary way to display `NTSTATUS` codes (ocaml/dune#11504, @MisterDA)

@Sylvain78

CHANGES: ### Fixed - Support HaikuOS: don't call `execve` since it's not allowed if other pthreads have been created. The fact that Haiku can't call `execve` from other threads than the principal thread of a process (a team in haiku jargon), is a discrepancy to POSIX and hence there is a [bug about it](https://dev.haiku-os.org/ticket/18665). (@Sylvain78, ocaml/dune#10953) - Fix flag ordering in generated Merlin configurations (ocaml/dune#11503, @voodoos, fixes ocaml/merlin#1900, reported by @vouillon) ### Added - Add `(format-dune-file <src> <dst>)` action. It provides a replacement to `dune format-dune-file` command. (ocaml/dune#11166, @nojb) - Allow the `--prefix` flag when configuring dune with `ocaml configure.ml`. This allows to set the prefix just like `$ dune install --prefix`. (ocaml/dune#11172, @rgrinberg) - Allow arguments starting with `+` in preprocessing definitions (starting with `(lang dune 3.18)`). (@amonteiro, ocaml/dune#11234) - Support for opam `(maintenance_intent ...)` in dune-project (ocaml/dune#11274, @art-w) - Validate opam `maintenance_intent` (ocaml/dune#11308, @art-w) - Support `not` in package dependencies constraints (ocaml/dune#11404, @art-w, reported by @hannesm) ### Changed - Warn when failing to discover root due to reads failing. The previous behavior was to abort. (@KoviRobi, ocaml/dune#11173) - Use shorter path for inline-tests artifacts. (@hhugo, ocaml/dune#11307) - Allow dash in `dune init` project name (ocaml/dune#11402, @art-w, reported by @saroupille) - On Windows, under heavy load, file delete operations can sometimes fail due to AV programs, etc. Guard against it by retrying the operation up to 30x with a 1s waiting gap (ocaml/dune#11437, fixes ocaml/dune#11425, @MSoegtropIMC) - Cache: we now only store the executable permission bit for files (ocaml/dune#11541, fixes ocaml/dune#11533, @ElectreAAS) - Display negative error codes on Windows in hex which is the more customary way to display `NTSTATUS` codes (ocaml/dune#11504, @MisterDA)

* Reduce path size for inline-tests artifacts Signed-off-by: Hugo Heuzard <hugo.heuzard@gmail.com>

hhugo mentioned this pull request Jan 16, 2025

Too easy to reach MAX_PATH on windows #11303

Open

hhugo force-pushed the shorter-path branch from 0dfde7c to 6f8bfdf Compare January 16, 2025 13:58

hhugo marked this pull request as ready for review January 16, 2025 14:46

hhugo added windows Issues that relate to Dune on Microsoft Windows and removed windows Issues that relate to Dune on Microsoft Windows labels Jan 16, 2025

hhugo mentioned this pull request Jan 16, 2025

Make sure wasmoo works on windows and update the CI ocsigen/js_of_ocaml#1797

Closed

nojb approved these changes Jan 21, 2025

View reviewed changes

hhugo force-pushed the shorter-path branch from 6f8bfdf to 6dd5d4f Compare January 21, 2025 08:24

hhugo force-pushed the shorter-path branch 3 times, most recently from 6dd5d4f to 52fd9bd Compare January 27, 2025 08:56

maiste added the test-suite label Jan 27, 2025

hhugo force-pushed the shorter-path branch from 52fd9bd to ba3dd72 Compare February 3, 2025 10:22

hhugo added 2 commits February 7, 2025 13:56

Reduce path size for inline-tests artifacts

4275a21

Signed-off-by: Hugo Heuzard <hugo.heuzard@gmail.com>

Alternative names

77c82bb

Signed-off-by: Hugo Heuzard <hugo.heuzard@gmail.com>

hhugo force-pushed the shorter-path branch from ba3dd72 to 77c82bb Compare February 7, 2025 12:56

_

538fd38

Signed-off-by: Rudi Grinberg <me@rgrinberg.com>

rgrinberg merged commit 01ec6fd into ocaml:main Feb 8, 2025
15 of 22 checks passed

maiste mentioned this pull request Mar 31, 2025

[new release] dune (15 packages) (3.18.0~alpha0) ocaml/opam-repository#27696

Closed

maiste mentioned this pull request Apr 3, 2025

[new release] dune (15 packages) (3.18.0) ocaml/opam-repository#27704

Merged

anmonteiro pushed a commit to anmonteiro/dune that referenced this pull request Apr 22, 2025

Shorter path for inline-tests (ocaml#11307)

567eeb2

* Reduce path size for inline-tests artifacts Signed-off-by: Hugo Heuzard <hugo.heuzard@gmail.com>

hhugo deleted the shorter-path branch June 6, 2025 08:41

Sudha247 pushed a commit to Sudha247/dune that referenced this pull request Jul 23, 2025

Shorter path for inline-tests (ocaml#11307)

5406645

* Reduce path size for inline-tests artifacts Signed-off-by: Hugo Heuzard <hugo.heuzard@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Shorter path for inline-tests#11307

Shorter path for inline-tests#11307
rgrinberg merged 3 commits intoocaml:mainfrom
hhugo:shorter-path

hhugo commented Jan 16, 2025 •

edited

Loading

Uh oh!

hhugo commented Jan 16, 2025

Uh oh!

nojb left a comment

Uh oh!

Uh oh!

nojb Jan 21, 2025

Uh oh!

hhugo Jan 27, 2025

Uh oh!

nojb Jan 27, 2025

Uh oh!

hhugo commented Jan 27, 2025

Uh oh!

hhugo commented Feb 7, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

hhugo commented Jan 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hhugo commented Jan 16, 2025

Uh oh!

nojb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nojb Jan 21, 2025

Choose a reason for hiding this comment

Uh oh!

hhugo Jan 27, 2025

Choose a reason for hiding this comment

Uh oh!

nojb Jan 27, 2025

Choose a reason for hiding this comment

Uh oh!

hhugo commented Jan 27, 2025

Uh oh!

hhugo commented Feb 7, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

hhugo commented Jan 16, 2025 •

edited

Loading