Skip to content

Update Wasm_of_ocaml action#11184

Merged
Leonidas-from-XIV merged 1 commit intoocaml:mainfrom
Leonidas-from-XIV:attempt-update-wasm
Dec 6, 2024
Merged

Update Wasm_of_ocaml action#11184
Leonidas-from-XIV merged 1 commit intoocaml:mainfrom
Leonidas-from-XIV:attempt-update-wasm

Conversation

@Leonidas-from-XIV
Copy link
Copy Markdown
Collaborator

The attempts to update the workflow as Wasm_of_ocaml has been merged upstream in ocsigen/js_of_ocaml#1724 and the wasm-dune branch is gone.

The attempts to update the workflow as Wasm_of_ocaml has been merged
upstream in ocsigen/js_of_ocaml#1724 and the
wasm-dune branch is gone.

Signed-off-by: Marek Kubica <marek@tarides.com>
@Leonidas-from-XIV Leonidas-from-XIV added the chore Something that just needs to be done. label Dec 5, 2024
@vouillon
Copy link
Copy Markdown
Member

vouillon commented Dec 5, 2024

Oh, sorry. I forgot this branch was still used.

@Leonidas-from-XIV
Copy link
Copy Markdown
Collaborator Author

No worries. However, I don't know what the state of wasm_of_ocaml or this workflow is, is the fix submitted the right solution or does it need something else? It does seem to pass CI successfully.

@vouillon
Copy link
Copy Markdown
Member

vouillon commented Dec 5, 2024

Yes, this is the right solution. The wasm_of_ocaml development has been moved to the js_of_ocaml repository.

@Leonidas-from-XIV Leonidas-from-XIV merged commit 5eeb823 into ocaml:main Dec 6, 2024
@Leonidas-from-XIV Leonidas-from-XIV deleted the attempt-update-wasm branch December 6, 2024 09:34
chris-armstrong pushed a commit to chris-armstrong/dune that referenced this pull request Jan 29, 2025
The attempts to update the workflow as Wasm_of_ocaml has been merged
upstream in ocsigen/js_of_ocaml#1724 and the
wasm-dune branch is gone.

Signed-off-by: Marek Kubica <marek@tarides.com>
Signed-off-by: Chris Armstrong <chris-armstrong@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Something that just needs to be done.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants