refactor(pkg): simplify depopts handling#11022
Merged
Conversation
8c8c625 to
52acca5
Compare
52acca5 to
49fe9f8
Compare
gridbugs
reviewed
Oct 21, 2024
gridbugs
approved these changes
Oct 21, 2024
In theory, this is also a bug fix because we are now using the same environment in both depopts and regular deps. However, I was unable to reproduce this as we lack full support for depopts. Signed-off-by: Rudi Grinberg <me@rgrinberg.com> <!-- ps-id: 9e85f5db-87b7-48e8-aa74-fa67a1c892b0 -->
49fe9f8 to
4a255df
Compare
anmonteiro
pushed a commit
to anmonteiro/dune
that referenced
this pull request
Nov 17, 2024
In theory, this is also a bug fix because we are now using the same environment in both depopts and regular deps. However, I was unable to reproduce this as we lack full support for depopts. Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The simplification comes from us resolving the depopts formula exactly in the same way as we do for regular deps.
In theory, this is also a bug fix because we are now using the same environment in both depopts and regular deps. However, I was unable to reproduce this as we lack full support for depopts.
Signed-off-by: Rudi Grinberg me@rgrinberg.com