chore: update vendored pp to 2.0.0#10938
Merged
Leonidas-from-XIV merged 1 commit intoocaml:mainfrom Sep 20, 2024
Merged
Conversation
Signed-off-by: Stephen Sherratt <stephen@sherra.tt>
555ff11 to
b5e56af
Compare
Collaborator
Author
|
Fixes #10934 |
Leonidas-from-XIV
approved these changes
Sep 20, 2024
Collaborator
Leonidas-from-XIV
left a comment
There was a problem hiding this comment.
Looks good, thanks! I like how removing the formatting constructor allowed us to get rid of some dodgy conversion code.
Collaborator
|
Merging since this fixes the annoying CI failure and I can rebase my PRs on top of this. |
This was referenced Sep 20, 2024
anmonteiro
pushed a commit
to anmonteiro/dune
that referenced
this pull request
Nov 17, 2024
Signed-off-by: Stephen Sherratt <stephen@sherra.tt>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.