Conversation
eff5fc7 to
44e7e36
Compare
18 tasks
44e7e36 to
43a12f3
Compare
Collaborator
Author
|
@ElectreAAS this is now ready, the individual commits should make sense for review. |
4815b9c to
6cb9608
Compare
rgrinberg
reviewed
Aug 1, 2024
christinerose
approved these changes
Aug 2, 2024
ElectreAAS
approved these changes
Aug 2, 2024
Collaborator
ElectreAAS
left a comment
There was a problem hiding this comment.
Bar my minuscule comment, everything looks good to me! Very happy to see this done :)
| os: ubuntu-latest | ||
| skip_test: true | ||
| # OCaml 5: | ||
| # OCaml 4: |
Collaborator
There was a problem hiding this comment.
Isn't this a typo? Or should we have a separate 4.14 CI run here?
Collaborator
Author
There was a problem hiding this comment.
Yes indeed the plan was to add a 4.14 build-only CI instead of the 4.13 one.
rgrinberg
approved these changes
Aug 2, 2024
40c6a89 to
096a999
Compare
This bumps the version of OCaml used in tests to 5.1.1.
The changes are:
- version numbers are changed
- CI is adjusted
- some hashes are changed
- the layout of the compiler is changed
- some error messages are changed
- Interesting changes to note:
- on OCaml 5, with the dev profile, jsoo triggers a warning
- the location of cmt files in install files is changed, because they
are compressed and binary substitution does not happen
At the time this PR is opened, 5.2 is available but requires more
changes around warnings and alerts in alias modules so it will be
updated in a second step.
Also, there are a few components that we're leaving behind:
- the monorepo benchmarks can be updated separately
- the benchmark in bench.Dockerfile can be updated separately
- coq cannot use OCaml 5 at the moment so it's forced to use 4.x
- 5.1.1 doesn't support MSVC so we leave the build on 4.14 for now.
Signed-off-by: Etienne Millon <me@emillon.org>
5c1b563 to
eae4106
Compare
anmonteiro
pushed a commit
to anmonteiro/dune
that referenced
this pull request
Nov 17, 2024
This bumps the version of OCaml used in tests to 5.1.1.
The changes are:
- version numbers are changed
- CI is adjusted
- some hashes are changed
- the layout of the compiler is changed
- some error messages are changed
- Interesting changes to note:
- on OCaml 5, with the dev profile, jsoo triggers a warning
- the location of cmt files in install files is changed, because they
are compressed and binary substitution does not happen
At the time this PR is opened, 5.2 is available but requires more
changes around warnings and alerts in alias modules so it will be
updated in a second step.
Also, there are a few components that we're leaving behind:
- the monorepo benchmarks can be updated separately
- the benchmark in bench.Dockerfile can be updated separately
- coq cannot use OCaml 5 at the moment so it's forced to use 4.x
- 5.1.1 doesn't support MSVC so we leave the build on 4.14 for now.
Signed-off-by: Etienne Millon <me@emillon.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bumps the version of OCaml used in tests to 5.1.1.
The changes should be straightforward to review:
Interesting changes to note:
At the time this PR is opened, 5.2 is available but requires more changes around warnings and alerts in alias modules so it will be updated in a second step.
Also, there are a few components that we're leaving behind:
bench.Dockerfilecan be updated separately