Conversation
d8bca21 to
16ced83
Compare
|
I don't get why warning 14 starts happening all of a sudden in the tests that disable it. Warning 26 is also disabled and is not showing up. |
|
We're installing melange through a git branch, maybe it's just that it has changed in the meantime? |
|
I did update that git branch, so it must be that; I’ll revert the update when I get a chance and stage the update on a different branch. I think until I do that I’ve broken dune tests. |
|
great, thanks. please use a hash instead of the branch name when you do :) |
c06322a to
fcc08af
Compare
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
fcc08af to
70efc35
Compare
|
alright, I reverted the update and will be taking a look into it in melange. also changed from branch to sha |
| .PHONY: melange | ||
| melange: | ||
| opam pin add -n melange.dev https://github.com/melange-re/melange.git#v4-414-dev | ||
| opam pin add -n melange.dev https://github.com/melange-re/melange.git#24e21cc42 |
There was a problem hiding this comment.
Is it worth adding a comment to explain to which branch the hash is pointing to? Like in the nix case. For those of us that are not hip 😄
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
|
FWIW I fixed the issue we found here in melange-re/melange#1118 |
* chore(nix): update flakes Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com> * chore: add comment to makefile Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com> * last update to nixpkgs Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com> --------- Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
No description provided.