Skip to content

test: show crash when defining a context named "install"#10472

Merged
anmonteiro merged 1 commit intoocaml:mainfrom
anmonteiro:anmonteiro/show-crash-context-name-install
May 1, 2024
Merged

test: show crash when defining a context named "install"#10472
anmonteiro merged 1 commit intoocaml:mainfrom
anmonteiro:anmonteiro/show-crash-context-name-install

Conversation

@anmonteiro
Copy link
Copy Markdown
Collaborator

There's a special Install.Context module that tracks this context.

log is already forbidden as a name in Context_name.of_string_opt, but "install" is a bit of a special case.

Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
@anmonteiro anmonteiro force-pushed the anmonteiro/show-crash-context-name-install branch from 1e597b0 to 9f07676 Compare May 1, 2024 00:04
@anmonteiro anmonteiro merged commit 7b5c579 into ocaml:main May 1, 2024
@anmonteiro anmonteiro deleted the anmonteiro/show-crash-context-name-install branch May 1, 2024 17:29
anmonteiro added a commit to anmonteiro/dune that referenced this pull request Nov 17, 2024
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants