refactor: treat deprecated lib case explicitly#10231
refactor: treat deprecated lib case explicitly#10231jchavarri wants to merge 2 commits intoocaml:mainfrom
Conversation
Signed-off-by: Javier Chávarri <javier.chavarri@gmail.com>
|
I'd keep it in #10231 . Off the top of my head, I don't see how this is going to help to implement enabled_if for libraries. |
|
The main reason is that to enable multi-context libs with the same name, we need to allow Essentially, the following line needs to change to remove the Line 74 in 1f80426 But if we do that change without introducing the new variant, we will break the deprecated libs use case. |
10231 is this PR. Which one are you referring to? |
|
I meant #10179. It could be very well the case that this PR is useful, but it's impossible to tell without seeing the final use of it. On its own, it does not yet offer any value (not in readability, performance, etc) |
brings the changes from ocaml#10231 Signed-off-by: Javier Chávarri <javier.chavarri@gmail.com>
|
ftr applied the changes in jchavarri@845ac40. |
brings the changes from ocaml#10231 Signed-off-by: Javier Chávarri <javier.chavarri@gmail.com>
This change will help with enabling multi-context libraries in #10179.
The reason is that with the changes in that PR, the checks in
create_db_from_stanzaschange a bit, with two redirects being a potentially valid situation (e.g. if there are two public libraries with the same name defined in different contexts).Having a way to explicitly recognize the deprecated library case allows to keep the behavior of that feature untouched while unlocking multi-context public libraries.