Skip to content

Conversation

@derrod
Copy link
Member

@derrod derrod commented Jul 2, 2023

Description

Fixes compilation when setting the C++ standard to 20+ by disabling char8_t.

Note that while #9183 introduces a deprecation warning in C++20 that gets treated as error, char8_t also causes failure in other cases where std::filesystem is used, such as obs-app.cpp.

Motivation and Context

We might want to start using C++20 at some point, and the less said about char8_t the better.

How Has This Been Tested?

Compiled on Windows with CMAKE_CXX_STANDARD set to 20.

Types of changes

  • Tweak (non-breaking change to improve existing functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants