Skip to content

UI: Fix utf-8 paths in shared updater components #9183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
derrod merged 1 commit into from
Jul 2, 2023
Merged

UI: Fix utf-8 paths in shared updater components #9183

derrod merged 1 commit into from
Jul 2, 2023

Conversation

@derrod
Copy link
Member

@derrod derrod commented Jun 30, 2023

Description

Fixes reading/writing files with non-ASCII characters in their path in the shared code of the update framework.

Motivation and Context

AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA

How Has This Been Tested?

Compiled and ran on my machine. Still needs to be tested on an affected system.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@derrod derrod added the Bug Fix Non-breaking change which fixes an issue label Jun 30, 2023
@derrod derrod force-pushed the fix-unicode-nonsense-frowning-emoji branch from 406e480 to e2cb843 Compare June 30, 2023 18:37
@derrod derrod force-pushed the fix-unicode-nonsense-frowning-emoji branch from e2cb843 to 3e99c01 Compare June 30, 2023 18:43
@derrod derrod added the Seeking Testers Build artifacts on CI label Jun 30, 2023
@derrod
Copy link
Member Author

derrod commented Jul 2, 2023

Confirmed this fixes the update check for usernames (and thus user folders) with special characters on Windows.

@derrod derrod merged commit 7773ea0 into obsproject:master Jul 2, 2023
@derrod derrod deleted the fix-unicode-nonsense-frowning-emoji branch July 2, 2023 03:10
@derrod derrod mentioned this pull request Jul 2, 2023
Merged
6 tasks
@SuslikV
Copy link
Contributor

SuslikV commented Jul 2, 2023 •
edited
Loading

It seems these changes addresses one part of this: https://obsproject.com/forum/threads/no-gpu-driver-available.167798/post-616613

@derrod
Copy link
Member Author

derrod commented Jul 2, 2023

Correct.

@RytoEX RytoEX added this to the OBS Studio (Next Release) milestone Aug 10, 2023
@derrod derrod mentioned this pull request Sep 1, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Bug Fix Non-breaking change which fixes an issue Seeking Testers Build artifacts on CI

Projects

None yet

Milestone

OBS Studio 30.0

Development

Successfully merging this pull request may close these issues.

3 participants

@derrod @SuslikV @RytoEX