UI: Fix crash when closing missing files window#4544
Merged
Conversation
Member
|
To confirm, this fixes #4359? |
Contributor
Author
|
It seems to be the same issue, so yes it should fix it. |
8b899ba to
39336cd
Compare
cg2121
added a commit
to cg2121/obs-studio
that referenced
this pull request
Apr 18, 2021
A crash would occur when clicking the 'x' button in the missing files dialog. This seemed to only happen in debug mode and using QT 5.15.0. Closes obsproject#4363 Fixes obsproject#4544
39336cd to
03f2b95
Compare
A crash would occur when clicking the 'x' button in the missing files dialog. This seemed to only happen in debug mode and using QT 5.15.0. Closes obsproject#4363 Fixes obsproject#4359
03f2b95 to
806380d
Compare
Contributor
Author
|
Updated to remove the lambda, as it is not needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A crash would occur when clicking the 'x' button in the missing files
dialog. This seemed to only happen in debug mode and using QT 5.15.0.
Closes #4363
Fixes #4359
Motivation and Context
Fixes crash that I found.
How Has This Been Tested?
Closed the dialog and made sure it didn't crash.
Types of changes
Checklist: