Skip to content

libobs: Add function to get module lib#3871

Merged
jp9000 merged 1 commit into
obsproject:masterfrom
cg2121:module-functions
Jan 26, 2021
Merged

libobs: Add function to get module lib#3871
jp9000 merged 1 commit into
obsproject:masterfrom
cg2121:module-functions

Conversation

@cg2121

@cg2121 cg2121 commented Dec 12, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This adds a function to find module library.

Co-authored-by: @Palakis

Motivation and Context

In order to easily find the library file needed to load the browser panels on Linux, these functions were added. This should work on Mac and Windows as well.

Used code made by @Palakis, as they were trying to make Linux browser panels work as well.

How Has This Been Tested?

Tested with obsproject/obs-browser#254

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@cg2121 cg2121 mentioned this pull request Dec 12, 2020
Merged
9 tasks
@WizardCM WizardCM added the kind/enhancement Enhancements are not bugs or new features but can improve usability or performance. label Dec 12, 2020
@notr1ch

notr1ch commented Dec 14, 2020

Copy link
Copy Markdown
Member

I don't think this should be modifying obs-module.h. That header is included by plugins - the MODULE_EXPORT define is for exporting symbols by plugins, eg obs_module_load().

@cg2121

cg2121 commented Dec 19, 2020

Copy link
Copy Markdown
Contributor Author

I've moved them now to obs.h

@WizardCM

WizardCM commented Jan 11, 2021

Copy link
Copy Markdown
Member

I have verified this works well on Ubuntu.

cg2121 added a commit to cg2121/obs-browser that referenced this pull request Jan 17, 2021
@cg2121
Use new modules functions to find obs-browser lib
5b7a92c 
Requires obsproject/obs-studio#3871
@jp9000

jp9000 commented Jan 25, 2021

Copy link
Copy Markdown
Member

Are you aware of the obs_get_module() function?

@cg2121 @Palakis
libobs: Add function to get module lib
cc92733 
This adds a function find module library.

Co-authored-by: Stéphane Lepin <stephane.lepin@gmail.com>
@cg2121 cg2121 force-pushed the module-functions branch 2 times, most recently from 93a3c4e to cc92733 Compare January 26, 2021 05:22
@cg2121 cg2121 changed the title libobs: Add module functions libobs: Add function to get module lib Jan 26, 2021
@cg2121

cg2121 commented Jan 26, 2021

Copy link
Copy Markdown
Contributor Author

@jp9000 didn't notice that function. I've updated it now to only add the module library function.

@jp9000

jp9000 commented Jan 26, 2021

Copy link
Copy Markdown
Member

Sorry about that. Figured you might've missed it.

@jp9000 jp9000 merged commit 99d10c2 into obsproject:master Jan 26, 2021
cg2121 added a commit to cg2121/obs-browser that referenced this pull request Jan 26, 2021
@cg2121
Use new module function to find obs-browser lib
c89f899 
Requires obsproject/obs-studio#3871
WizardCM pushed a commit to cg2121/obs-browser that referenced this pull request Jan 26, 2021
@cg2121 @WizardCM
Use new module function to find obs-browser lib
5d4197f 
Requires obsproject/obs-studio#3871
@cg2121 cg2121 deleted the module-functions branch November 8, 2021 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

kind/enhancement Enhancements are not bugs or new features but can improve usability or performance.

Projects

None yet

Milestone

OBS Studio 27.0

Development

Successfully merging this pull request may close these issues.

5 participants

@cg2121 @notr1ch @WizardCM @jp9000 @dodgepong