frontend: Fix build with Qt 6.10#12321
Conversation
|
In our context, this is not the right fix. |
The 'Qt6FooPrivate' targets have been split into separate CMake files in Qt 6.9, and require a 'find_package(Qt6FooPrivate)' call starting with Qt 6.10. See also: https://bugreports.qt.io/browse/QTBUG-87776
I see. |
|
The CMake formatting check is failing. If OBS Studio itself does not use Qt6GuiPrivate, then I'm not convinced we need to merge this change. |
Noticed, but I didn't get into guessing what it isn't happy about yet exactly, as there seem to be no hints at all in the log, and that's probably not even necessary if this is not the correct way to fix the build.
If it's not the proper way to go, certainly not, but the build failure will still be there. At this time, as an alternative, I can only think of removing the link target if it's indeed unused, and a quick test shows that things do seem to at least compile if they are removed in the cmake files referenced to in the error messages: |
|
Closing in favour of #12328 |
While obs-studio itself is built with 'disable-werror' these days, '-Werror' in the the 'libobs.pc.in' causes other projects potentially unwanted build issues [1]. Also add the qt-6.10 patch to the git build, since the fix is still not merged upstream after half a year [2][3], and qt-6.10 has been out in the wilds for a while now. 1. https://bugs.gentoo.org/966311 2. obsproject/obs-studio#12321 3. obsproject/obs-studio#12328 Bug: https://bugs.gentoo.org/966311 Signed-off-by: Jimi Huotari <chiitoo@gentoo.org>
Description
Add
Qt6GuiPrivatetarget to the Qtfind_package()call to fix compiling against Qt 6.10.Motivation and Context
The 'Qt6FooPrivate' targets have been split into separate CMake files in Qt 6.9, and require a 'find_package(Qt6FooPrivate)' call starting with Qt 6.10.
See also: https://bugreports.qt.io/browse/QTBUG-87776
How Has This Been Tested?
Tested compiling and running on Gentoo Linux with Qt 6.10.
Types of changes
Checklist: