obs-browser: Update version to 2.24.5#11910
Merged
Merged
Conversation
tytan652
approved these changes
Feb 28, 2025
tytan652
left a comment
Collaborator
There was a problem hiding this comment.
LGTM for the Flatpak side, and Flatpak CI is good ignoring Crowdin shenanigans.
082a0a2 - Don't emit a normal call to a function for closing panels 663dc38 - Disable modern game controller API on Windows 4023fad - Log fatal CEF crashes to file 52c1527 - Print browser source renderer crashes to OBS log af0651b - Log error if CefInitialize fails 8223215 - Revert "Enable Qt message loop on Linux" 16ff0fa - Update version to 2.24.5 Additionally, update buildspec.json and build-aux/modules/99-cef.json to use the new CEF builds. This is being done because the changes in obs-browser specifically are meant to work with a CEF build compiled with use_gtk=false.
c6b9a3d to
2d4758f
Compare
WizardCM
approved these changes
Mar 1, 2025
WizardCM
left a comment
Member
There was a problem hiding this comment.
Verified it correctly downloads the updated dep on Windows. All hashes look correct. Submodule changes look good too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
obs-browser: Update version to 2.24.5
082a0a2 - Don't emit a normal call to a function for closing panels
663dc38 - Disable modern game controller API on Windows
4023fad - Log fatal CEF crashes to file
52c1527 - Print browser source renderer crashes to OBS log
af0651b - Log error if CefInitialize fails
8223215 - Revert "Enable Qt message loop on Linux"
16ff0fa - Update version to 2.24.5
Additionally, update buildspec.json and build-aux/modules/99-cef.json to use the new CEF builds. This is being done because the changes in obs-browser specifically are meant to work with a CEF build compiled with use_gtk=false.
Motivation and Context
Fixes #11485
Fixes obsproject/obs-browser#468
How Has This Been Tested?
Tested on obsproject/obs-browser#472 and off-thread by others.
Types of changes
Checklist: