Revert "Enable Qt message loop on Linux"#472
Conversation
This reverts commit 98d94a4.
|
Everything looks good with a new build of cef and this applied. |
RytoEX
left a comment
There was a problem hiding this comment.
This seems fine.
Note: this must be paired with new CEF builds that use use_gtk=false.
|
I'm curious, what's the issue when the CEF build has |
|
Qt by default relies on Glib for its event loop, which completely goes wrong with the GTK inside CEF (e.g. obsproject/obs-studio#7146). We also normally should not need use_gtk or use_qt being enabled in our usecase, since both can lead to side effects. |
|
@tytan652 Thanks! I hadn't noticed that since browser panels don't work on Wayland anyway. Is the GN define list used for OBS CEF builds viewable somewhere? |
|
I can give it to you, note that we enable H264 decoding in ours. For the latest CEF 6533, I used |
|
Thanks! Looks like the only relevant override there is |
Description
Closes obsproject/obs-studio#11485
This reverts commit 98d94a4.
Motivation and Context
Performance issues were met by multiple users.
So back to
use_gtk=falsebuilds.How Has This Been Tested?
Used
use_gtk=falsefor testing (even tested with #453) everything seem to work properly.Types of changes
Checklist: