Skip to content

frontend: Enable browser hw accel toggle under Linux#11262

Merged
RytoEX merged 1 commit into
obsproject:masterfrom
tytan652:linux_hwaccel_pr
May 24, 2025
Merged

frontend: Enable browser hw accel toggle under Linux#11262
RytoEX merged 1 commit into
obsproject:masterfrom
tytan652:linux_hwaccel_pr

Conversation

@tytan652

@tytan652 tytan652 commented Sep 11, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

Depends on:

Enable browser hw accel toggle under Linux

Motivation and Context

Add toggle for hwaccel support under Linux

How Has This Been Tested?

Set the checkbox to true and the feature was enabled, and then set to false and it got disabled.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@tytan652 tytan652 mentioned this pull request Sep 11, 2024
Merged
6 tasks
@tytan652 tytan652 added platform/linux Categorizes issue or PR as affecting Linux specifically kind/feature Functionality or other elements that the project doesn't currently have. labels Sep 11, 2024
jmickelonis added a commit to jmickelonis/obs-studio that referenced this pull request Sep 30, 2024
@jmickelonis
Integrated PR obsproject#11262 (UI: Enable browser hw accel toggle un…
0a06f30 
…der Linux).
@tytan652 tytan652 force-pushed the linux_hwaccel_pr branch 2 times, most recently from e798f5b to 7c9e360 Compare October 20, 2024 06:02
@tytan652 tytan652 force-pushed the linux_hwaccel_pr branch 2 times, most recently from 4261f1f to 76e64b8 Compare January 30, 2025 18:39
@tytan652 tytan652 changed the title UI: Enable browser hw accel toggle under Linux frontend: Enable browser hw accel toggle under Linux Jan 30, 2025
@tytan652 tytan652 marked this pull request as ready for review April 2, 2025 05:25
@tytan652 tytan652 mentioned this pull request Apr 30, 2025
Merged
6 tasks
WizardCM
WizardCM reviewed May 4, 2025
View reviewed changes
Comment thread frontend/settings/OBSBasicSettings.cpp
WizardCM
WizardCM approved these changes May 13, 2025
View reviewed changes

@WizardCM WizardCM left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that this works on Intel Mesa and AMD without issue via chrome://gpu and code changes look good. Correctly disabled on NVIDIA.

@RytoEX RytoEX requested a review from Warchamp7 May 13, 2025 17:47
RytoEX
RytoEX approved these changes May 13, 2025
View reviewed changes

@RytoEX RytoEX left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine code-wise. Exposes a checkbox option to Linux that's currently only visible on Windows and macOS. @Warchamp7 ?

@RytoEX RytoEX self-assigned this May 13, 2025
@RytoEX RytoEX merged commit bdebea3 into obsproject:master May 24, 2025
15 checks passed
@RytoEX RytoEX added this to the OBS Studio 31.1 milestone May 24, 2025
@tytan652 tytan652 deleted the linux_hwaccel_pr branch May 24, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RytoEX RytoEX RytoEX approved these changes

@WizardCM WizardCM WizardCM approved these changes

@Warchamp7 Warchamp7 Warchamp7 approved these changes

Assignees

@RytoEX RytoEX

Labels

kind/feature Functionality or other elements that the project doesn't currently have. platform/linux Categorizes issue or PR as affecting Linux specifically

Projects

None yet

Milestone

OBS Studio 31.1

Development

Successfully merging this pull request may close these issues.

4 participants

@tytan652 @RytoEX @WizardCM @Warchamp7