fix: added conditional so default is not always set and env vars honored #3304
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1d68540 to
b2a50cb
Compare
b2a50cb to
0ca010a
Compare
…honored oauth2-proxy#3303 Signed-off-by: Drew Foehn <drew@pixelburn.net>
0ca010a to
1622408
Compare
4 tasks
tuunit
approved these changes
Jan 14, 2026
sourava01
pushed a commit
to sourava01/oauth2-proxy
that referenced
this pull request
Jan 15, 2026
…honored oauth2-proxy#3303 (oauth2-proxy#3304) Signed-off-by: Drew Foehn <drew@pixelburn.net>
pierluigilenoci
pushed a commit
to pierluigilenoci/oauth2-proxy
that referenced
this pull request
Jan 15, 2026
…honored oauth2-proxy#3303 (oauth2-proxy#3304) Signed-off-by: Drew Foehn <drew@pixelburn.net> Signed-off-by: Pierluigi Lenoci <pierluigi.lenoci@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
adds a conditional when ensuredefaults runs so that env var options are set
Motivation and Context
fixes an issue where the config is set by env var and the default does not overwrite it
fixes #3303
How Has This Been Tested?
Locally
Checklist: