fix: session refresh handling in OIDC provider #3267
Merged
+6
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
gysel
commented
Nov 20, 2025
- `s.Refreshed` was always `false` as the session object was not updated - `ValidateURL` is, by default, not configured for OIDC providers. Access token validation now only happens when a validation endpoint is available. Signed-off-by: Michael Gysel <michael.gysel@unblu.com>
Signed-off-by: Michael Gysel <michael.gysel@unblu.com>
825d799 to
174621f
Compare
tuunit
approved these changes
Jan 14, 2026
sourava01
pushed a commit
to sourava01/oauth2-proxy
that referenced
this pull request
Jan 15, 2026
* Fix session refresh handling in OIDC provider - `s.Refreshed` was always `false` as the session object was not updated - `ValidateURL` is, by default, not configured for OIDC providers. Access token validation now only happens when a validation endpoint is available. Signed-off-by: Michael Gysel <michael.gysel@unblu.com> * Update changelog Signed-off-by: Michael Gysel <michael.gysel@unblu.com> --------- Signed-off-by: Michael Gysel <michael.gysel@unblu.com>
pierluigilenoci
pushed a commit
to pierluigilenoci/oauth2-proxy
that referenced
this pull request
Jan 15, 2026
* Fix session refresh handling in OIDC provider - `s.Refreshed` was always `false` as the session object was not updated - `ValidateURL` is, by default, not configured for OIDC providers. Access token validation now only happens when a validation endpoint is available. Signed-off-by: Michael Gysel <michael.gysel@unblu.com> * Update changelog Signed-off-by: Michael Gysel <michael.gysel@unblu.com> --------- Signed-off-by: Michael Gysel <michael.gysel@unblu.com> Signed-off-by: Pierluigi Lenoci <pierluigi.lenoci@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up for #1933 and fixed the session refresh for providers that don't renew the ID token.
Description
s.Refreshedwas alwaysfalseas the session object was not updated inredeemRefreshToken()ValidateURLis, by default, not configured for OIDC providers. Access token validation should only happen when a validation endpoint is available.Motivation and Context
How Has This Been Tested?
I started the application in the debugger and validated the refresh flow with and without a configured
validate_urlagainst a Keycloak IdP.Checklist: