feat: more aggressively truncate logged access_token #3264
Merged
+9
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0de14d0 to
636c112
Compare
tuunit
reviewed
Nov 16, 2025
…s_token - leaking half of the access token to the logs seems problematic from a security point of view - also noisier than necessary logging - fixed by truncating to at most first 5 chars (e.g. `ya29.`) Signed-off-by: Martin Nowak <code@dawg.eu>
…nd changelog Signed-off-by: Jan Larwig <jan@larwig.com>
636c112 to
7e53271
Compare
tuunit
approved these changes
Jan 14, 2026
sourava01
pushed a commit
to sourava01/oauth2-proxy
that referenced
this pull request
Jan 15, 2026
* partly address oauth2-proxy#2120 and more aggressively truncate access_token - leaking half of the access token to the logs seems problematic from a security point of view - also noisier than necessary logging - fixed by truncating to at most first 5 chars (e.g. `ya29.`) Signed-off-by: Martin Nowak <code@dawg.eu> * feat: more aggressively truncate logged access_token; add unit test and changelog Signed-off-by: Jan Larwig <jan@larwig.com> --------- Signed-off-by: Martin Nowak <code@dawg.eu> Signed-off-by: Jan Larwig <jan@larwig.com> Co-authored-by: Jan Larwig <jan@larwig.com>
pierluigilenoci
pushed a commit
to pierluigilenoci/oauth2-proxy
that referenced
this pull request
Jan 15, 2026
* partly address oauth2-proxy#2120 and more aggressively truncate access_token - leaking half of the access token to the logs seems problematic from a security point of view - also noisier than necessary logging - fixed by truncating to at most first 5 chars (e.g. `ya29.`) Signed-off-by: Martin Nowak <code@dawg.eu> * feat: more aggressively truncate logged access_token; add unit test and changelog Signed-off-by: Jan Larwig <jan@larwig.com> --------- Signed-off-by: Martin Nowak <code@dawg.eu> Signed-off-by: Jan Larwig <jan@larwig.com> Co-authored-by: Jan Larwig <jan@larwig.com> Signed-off-by: Pierluigi Lenoci <pierluigi.lenoci@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ya29.)Motivation and Context
Leaking too much of the access token could expose
How Has This Been Tested?
This is covered by an existing unittest.
Checklist: