Reverse the order of the middleware when they applied in gorilla/mux implementation #842
+21
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for this - looks like this was because I copy-pasta'd Chi's server, and was resolved there in #787 |
jamietanna
requested changes
Nov 13, 2022
Member
jamietanna
left a comment
There was a problem hiding this comment.
Looks good - only requested change is that similar to the Chi PR, we add a compatibility option to allow folks to opt-in to these?
Contributor
Author
|
@jamietanna |
jamietanna
approved these changes
Nov 25, 2022
Member
jamietanna
left a comment
There was a problem hiding this comment.
Looks good, thanks for the changes 🙌
Only thought I have is whether we should rename the flag:
-apply-gorilla-mux-middleware-first-to-last
+apply-gorilla-middleware-first-to-last
Given the configuration to generate gorilla/mux servers is gorilla-server?
Contributor
Author
|
Understood. Since |
adrianpk
pushed a commit
to foorester/oapi-codegen
that referenced
this pull request
Jan 16, 2024
…implementation (oapi-codegen#842) * Reverse the order of the middleware when they apopted in gorilla/mux implementation * Add config to keep compatibility * Rename option by omitting
adrianpk
added a commit
to foorester/oapi-codegen
that referenced
this pull request
May 31, 2024
…implementation (oapi-codegen#842) * Reverse the order of the middleware when they apopted in gorilla/mux implementation * Add config to keep compatibility * Rename option by omitting
danicc097
pushed a commit
to danicc097/oapi-codegen
that referenced
this pull request
Aug 31, 2024
…implementation (oapi-codegen#842) * Reverse the order of the middleware when they apopted in gorilla/mux implementation * Add config to keep compatibility * Rename option by omitting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #841