Fix broken build due to kin backwards-incompatible change#322
Conversation
…)" This reverts commit 88f937a. The kin legacy routers force pulling in kin-openapi@0.52.0 which requires Go 1.16
|
I had to roll this back. Pulling in that routers/legacy package forces kin-openapi 0.52.0, which uses the //go:embed directive, which breaks on go 1.14, which is our minimum supported version. |
|
Ah, I thought it was fine since oapi-codegen was using I'm guessing that issues like these are going to be common as long as kin-openapi is sub-v1 and continues having breaking changes, which is unfortunate, but I guess that's what we get for depending on something sub-v1. For now, I'll work around this by depending on my own fork. Thanks for the good work! |
|
Hi, I maintain kin-openapi. As you may have noted the dependency on go:embed is only in a test. Let me see if I can have this test run iff go>1.14. |
|
Oh cool! @fenollp - Thank you so much for your work on kin-openapi. I can't imagine writing API's without it. |
…en#322) Co-authored-by: Marcin Romaszewicz <47459980+deepmap-marcinr@users.noreply.github.com>
…pi-codegen#322)" This reverts commit e0a6e90. The kin legacy routers force pulling in kin-openapi@0.52.0 which requires Go 1.16
…en#322) Co-authored-by: Marcin Romaszewicz <47459980+deepmap-marcinr@users.noreply.github.com>
…pi-codegen#322)" This reverts commit 88f937a. The kin legacy routers force pulling in kin-openapi@0.52.0 which requires Go 1.16
There was a backwards-incompatible change in
github.com/getkin/kin-openapi0.51.0: getkin/kin-openapi#326This PR fixes the build & hopefully maintains the old behavior. Unfortunately, this means panicking on error, since that's what kin-openapi used to do: https://github.com/getkin/kin-openapi/blob/v0.50.0/openapi3filter/router.go#L87-L94