feat: allow round trip middleware per operation#156
feat: allow round trip middleware per operation#156pseudo-su wants to merge 4 commits intooapi-codegen:mainfrom
Conversation
|
This is exactly the use case I have, so I would love to see a complete example in your pseudo-su /golang-service-template repo |
|
@StevenACoffman I haven't forgotten about this, you make a good point about examples... I might actually add some more tests cases to this PR that would also help somewhat in capturing examples. I have a few open PRs for My preference was to get things merged (where possible) before spending too much time messing about with a temporary fork. |
StevenACoffman
left a comment
There was a problem hiding this comment.
I think this is ready to merge with this minor case change.
|
@deepmap-marcinr This one is ready too! |
refactor: fix case Co-Authored-By: Steve Coffman <StevenACoffman@users.noreply.github.com>
48a255b to
474f343
Compare
|
@pseudo-su Hmmm, I think your rebase you need to regenerate because now there's some test failures. |
|
I need to fix some things and add those example/tests I mentioned, working on it now |
|
Ok @StevenACoffman three main things changed and this should be good now.
EG it was this responses:
200:
application/json:instead of responses:
200:
content:
application/json: |
|
Thanks, yes, this works for us in our client. Nice improvement! @deepmap-marcinr Ready for you! |
|
What is the status of this PR? Is there any other way to set custom behavior? |
Looks like this is the only way to inject the retry client, there's also oapi-codegen/oapi-codegen#150 which is in progress via oapi-codegen/oapi-codegen#156
|
@oapi-codegen any reason why this wasn't approved/merged (aside from the current merge conflicts)? |
Reference implementation to cater to the use-cases I described in #150
Notes
Fixes #150