fix(template): fix strict-interface template #1132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se content type uses string type Signed-off-by: Sarath Sadasivan Pillai <sarathsp06@gmail.com>
debuggerpk
pushed a commit
to breuHQ/oapi-codegen
that referenced
this pull request
Sep 18, 2023
…se content type uses string type (oapi-codegen#1132) Signed-off-by: Sarath Sadasivan Pillai <sarathsp06@gmail.com>
|
@sarathsp06 @deepmap-marcinr Looks like this PR broke the echo strict server: /healthz:
get:
tags: [Service]
summary: Liveness probe
description: Is the app alive or dead?
operationId: livenessProbe
responses:
'200':
description: Ok
content: {text/plain: {example: OK}}
headers: {X-Request-Id: {schema: {$ref: '#/components/schemas/RequestID'}, description: Request ID}}
Texttype LivenessProbe200TextResponse string
func (response LivenessProbe200TextResponse) VisitLivenessProbeResponse(w http.ResponseWriter) error {
w.Header().Set("Content-Type", "text/plain")
w.Header().Set("X-Request-Id", fmt.Sprint(response.Headers.XRequestId))
w.WriteHeader(200)
_, err := w.Write([]byte(response.Body))
return err
}Configpackage: openapi
generate:
echo-server: true
strict-server: true
models: true
embedded-spec: true |
danicc097
pushed a commit
to danicc097/oapi-codegen
that referenced
this pull request
Aug 31, 2024
…se content type uses string type (oapi-codegen#1132) Signed-off-by: Sarath Sadasivan Pillai <sarathsp06@gmail.com>
jamietanna
pushed a commit
that referenced
this pull request
Sep 20, 2024
Member
|
This is being reverted as part of #1773, apologies for the impact! |
jamietanna
pushed a commit
that referenced
this pull request
Sep 20, 2024
This was referenced Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix strict-interface template to make sure text response content type uses string type.
This is in reference to #1130 . The code change is probably not semantically correct, happy to make appropriate changes