Merged
Conversation
34 tasks
bc0c8f4 to
b97c40a
Compare
3749f28 to
ecaccf2
Compare
4aed004 to
369a756
Compare
|
@rui-mo We cannot use toNano in Timestamp.h compare function, for Timestamp::lowest, toNano will overflow. |
Collaborator
Author
@liujiayi771 Thanks for your review! This issue and the |
c10b855 to
588370a
Compare
zhejiangxiaomai
pushed a commit
to zhejiangxiaomai/velox
that referenced
this pull request
May 18, 2023
Add a drafted timestamp reader. Support timestamp in substrait, and add some validations for unsupported cases.
zhejiangxiaomai
pushed a commit
to zhejiangxiaomai/velox
that referenced
this pull request
Jun 26, 2023
Add a drafted timestamp reader. Support timestamp in substrait, and add some validations for unsupported cases.
marin-ma
pushed a commit
to marin-ma/velox-oap
that referenced
this pull request
Dec 15, 2023
* add the dwrf write support * use C ABI to pass the schema and record batch * format style
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a drafted timestamp reader. Support timestamp in substrait, and add some validations for unsupported cases.