Skip to content

Fix build with -DDISABLE_PARCHECK=yes by adding missing include#514

Merged
dnzbk merged 2 commits intonzbgetcom:developfrom
sbraz:setfill_iomanip
Feb 25, 2025
Merged

Fix build with -DDISABLE_PARCHECK=yes by adding missing include#514
dnzbk merged 2 commits intonzbgetcom:developfrom
sbraz:setfill_iomanip

Conversation

@sbraz
Copy link
Copy Markdown
Contributor

@sbraz sbraz commented Feb 24, 2025

Otherwise, the build fails with error: ‘setfill’ is not a member of ‘std’.

Description

Fixes the build when -DDISABLE_PARCHECK=yes is used.

Lib changes

N/A

Testing

Built nzbget and ran ctest.

Otherwise, the build fails with "error: ‘setfill’ is not a member of
‘std’".
@sbraz
Copy link
Copy Markdown
Contributor Author

sbraz commented Feb 24, 2025

Hi @dnzbk, would you please consider adding a -DDISABLE_PARCHECK=yes job to your CI to avoid similar issues in future?

@dnzbk dnzbk self-requested a review February 25, 2025 03:49
@dnzbk
Copy link
Copy Markdown
Collaborator

dnzbk commented Feb 25, 2025

Hi @dnzbk, would you please consider adding a -DDISABLE_PARCHECK=yes job to your CI to avoid similar issues in future?

I'll definitely consider this option.

Thank you for the fix!

@dnzbk dnzbk merged commit e7b885c into nzbgetcom:develop Feb 25, 2025
3 checks passed
@dnzbk dnzbk mentioned this pull request Mar 5, 2025
dnzbk added a commit that referenced this pull request Mar 6, 2025
## Description

  - Bug fixes:
    - Renaming of the temporary `*.out.tmp` output file to its original filename
    - Improved deobfuscation of `[PRiVATE]-...` groups [#516](#516)
    - Build with `-DDISABLE_PARCHECK=yes` [#514](#514)
    - Installed Python on Windows could not be found, despite being accessible in the console [#515](#515)

  - For developers:
    - Added more test workflows
        - OpenBSD build/tests
        - FreeBSD tests
        - Linux build/tests with disabled parcheck
        - macOS brew install from head (develop branch only) [#519](#519)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants