Remove mathPlayer includes#48
Merged
Merged
Conversation
9 tasks
seanbudd
approved these changes
Nov 19, 2025
SaschaCowley
added a commit
to nvaccess/nvda
that referenced
this pull request
Nov 20, 2025
Closes #19165 ### Summary of the issue: MathPlayer is no longer maintained and is not 64-bit compatible. ### Description of user facing changes: MathPlayer is no longer supported by NVDA. ### Description of developer facing changes: MathPlayer code has been removed. ### Description of development approach: * Deleted the `mathPres.mathPlayer` module * Removed `mathPlayer_sconscript` and its callers from the build system * Fixed a few comments and strings that mentioned MathPlayer * Removed MathPlayer from miscDeps nvaccess/nvda-misc-deps#48 ### Testing strategy: Rebuilt NVDA and ensured that it still works and MathCAT continues to function. ### Known issues with pull request: None
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes MathPlayer includes from miscDeps.
Part of nvaccess/nvda#19239