Remove unused dependencies#22
Merged
michaelDCurran merged 2 commits intonvaccess:masterfrom Jul 27, 2021
Merged
Conversation
- espeakedit.exe - eSpeak NG has ability to build voice files natively - epydoc - were using Sphinx as of nvaccess/nvda#9968 - Boost - were using optional from C++ 17 as of nvaccess/nvda#9661
This reverts commit 9121704.
Contributor
|
Does this have a corresponding PR for NVDA yet? |
Contributor
Author
|
Not yet - I feel it would be better to have this merged into master of misc-deps first and then I'll create a PR against NVDA repo. |
Contributor
Author
|
@michaelDCurran Is this on your radar for 2021.3 perhaps? While I've tested this rather torougly and I don;t expect any regression merging stuff like this at the beginning of the dev cycle seems safer. |
michaelDCurran
approved these changes
Jul 27, 2021
michaelDCurran
added a commit
to nvaccess/nvda
that referenced
this pull request
Jul 27, 2021
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently misc-deps contains some unused dependencies namely:
espeakedit.exeis not necessary any longer as of Switch to eSpeak NG in NVDA distribution nvda#5651I've also reverted #20 to make it easier to update misc-deps in NVDA we're using BRLAPI for Python 3.7 anyway.
Testing:
Executed scons source from a clean NVDA repo with these changes ensured that everything builds correctly in particular made sure that BRLAPI and eSpeak are functional.
I've also made sure the developer documentation builds correctly.