This repository was archived by the owner on Jul 3, 2025. It is now read-only.
Conversation
Merge translations from l10n
Fixup of #16686 Fixes #16847 Summary of the issue: When updating a portable copy either from the auto-update check UX, or through the portable copy CLI, a warning is shown to confirm if a user wants to update and overwrite the portable copy. This is not ideal UX, as the update check UX should assume the user wants to update, same with the portable copy CLI. Additionally, some translator strings in #16686 were not formatted correctly Description of user facing changes Warnings are no longer shown when updating a portable copy via the auto-update UX or via CLI. Warnings are still shown when overwriting any other directory via CLI. Messages in warning dialogs are now translatable correctly Description of development approach Fix format of translation strings check if an update is being performed when creating a portable copy via CLI, do not warn in that case. The portable copy auto-update UX uses the CLI to perform the update.
Fixes #16704 Fixup of #15967 Summary of the issue: In the following code block: release-2024.2/source/addonHandler/__init__.py#L432-L454 If an error is raised from running addon.runInstallTask("onInstall"), it is caught, and then re-raised as AddonError However, this exception is caught again by the finally statement returning the add-on returning from finally suppresses the exception. This means the callers don't correctly handle the expected exception, as it is suppressed, where it should instead prevent the installation from continuing. We have to return the add-on to perform clean up tasks, but we have to know exceptions were raised to cancel the add-on installation Description of user facing changes Add-on installation failures should fail gracefully Description of development approach Instead of raising exceptions, store them and exit the installation process when a failure occurs. If exceptions are stored, cancel the installation and perform the require clean-up tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.