Portable copy safe creation fixups#16850
Merged
Merged
Conversation
Contributor
WalkthroughThe changes introduce a new variable Changes
Sequence DiagramsOld Flow: Directory Warning LogicsequenceDiagram
participant User
participant NVDA
participant Directory
User->>NVDA: Initiate Portable Installation
NVDA->>Directory: Check if Directory is Non-Empty
Directory-->>NVDA: Non-Empty Directory
NVDA->>User: Display Warning Dialog
New Flow: Updated Directory Warning LogicsequenceDiagram
participant User
participant NVDA
participant Directory
User->>NVDA: Initiate Portable Installation
NVDA->>Directory: Check if NVDA Exists in Directory
Directory-->>NVDA: NVDA Exists
NVDA->>NVDA: Set isUpdate = True
NVDA->>Directory: Check if Directory is Non-Empty
Directory-->>NVDA: Non-Empty Directory
alt isUpdate is True
NVDA->>User: Skip Warning Dialog
else isUpdate is False
NVDA->>User: Display Warning Dialog
end
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
michaelDCurran
approved these changes
Jul 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixup of #16686
Fixes #16847
Summary of the issue:
When updating a portable copy either from the auto-update check UX, or through the portable copy CLI, a warning is shown to confirm if a user wants to update and overwrite the portable copy.
This is not ideal UX, as the update check UX should assume the user wants to update, same with the portable copy CLI.
Additionally, some translator strings in #16686 were not formatted correctly
Description of user facing changes
Warnings are no longer shown when updating a portable copy via the auto-update UX or via CLI.
Warnings are still shown when overwriting any other directory via CLI.
Messages in warning dialogs are now translatable correctly
Description of development approach
Fix format of translation strings
check if an update is being performed when creating a portable copy via CLI, do not warn in that case.
The portable copy auto-update UX uses the CLI to perform the update.
Testing strategy:
Known issues with pull request:
Code Review Checklist:
Summary by CodeRabbit
New Features
Bug Fixes