UI Automation in Windows Console: disable filtering when tab is pressed#9936
Closed
codeofdusk wants to merge 1 commit into
Closed
UI Automation in Windows Console: disable filtering when tab is pressed#9936codeofdusk wants to merge 1 commit into
codeofdusk wants to merge 1 commit into
Conversation
codeofdusk
added a commit
to codeofdusk/nvda
that referenced
this pull request
Jul 16, 2019
This comment has been minimized.
This comment has been minimized.
feerrenrut
approved these changes
Jul 26, 2019
Contributor
|
I won't merge this yet. @codeofdusk first can you confirm if there is any interdependency between these Pull requests? |
Contributor
Author
|
This was intended as a backported change from #9915 to beta, which is no longer relevant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Related to #9614. Related to, but does not fix, #6095.
Summary of the issue:
When pressing tab in UIA consoles, very short completions are not read.
Description of how this pull request fixes the issue:
When tab is pressed, a new
self._hasTabflag on UIA consoles is set toTrue, causing the filtering logic in_reportNewTextto be temporarily disabled.Testing performed:
On Windows 10 1903 in a UIA console:
Before the change: NVDA said nothing.
After the change: NVDA said "w14".
This PR does not affect legacy consoles.
Known issues with pull request:
None.
Change log entry:
None.