Browseable Messages - Centered and enlarged (#9910)#9911
Merged
feerrenrut merged 7 commits intoAug 10, 2020
Conversation
Contributor
|
CC @feerrenrut, @nishomotz
|
1ea38dd to
553740d
Compare
553740d to
4e45956
Compare
Contributor
Author
|
Rebased onto latest master |
feerrenrut
approved these changes
Aug 10, 2020
feerrenrut
left a comment
Contributor
There was a problem hiding this comment.
Thanks @JulienCochuyt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Fixes #9910
Summary of the issue:
Browseable messages, as produced with
ui.browseableMessageare shown in a tiny window, located near the top-left corner of the display, sometimes partially off-screen.These limitations do not encourage authors to leverage the offered functionality - currently used only for format related info.
Looking at the source, it is clear the original intention was to have the window centered on the screen:
DIALOG_OPTIONS = "dialogWidth:350px;dialogHeight:140px;resizable:yes;center:yes;help:no"The "center" option, which defaults to "yes", is misinterpreted at least with newer Internet Explorer versions. To obtain the desired behavior - a centered window - it should be removed.
Description of how this pull request fixes the issue:
Testing performed:
NVDA+F twice quickly.
Known issues with pull request:
Change log entry:
I doubt it deserves to be announced.
Section: Changes
Information reported in browse mode, such as the formatting info with NVDA+F, are now displayed in a slightly bigger window centered on screen.