AppModule: Customize retrieval of status bar object or TextInfo (#4640)#9792
Conversation
|
Hi, Which apps and scenarios did you test this against? The most prominent scenario is viewing file/folder information in File Explorer (Windows Explorer in Windows 7 and earlier). Thanks. |
|
Hi Joseph, This PR is barely a proof of concept. The scenarios for which this feature is beneficial are IMHO:
|
|
4f7c44c: Rebased onto latest master. |
|
Rebased onto latest master and linted. |
|
While it is certainly too late to include it into 2019.3 it would be great if it could be considered for the next release. It is requested quite often and would unblock a few issues cc @feerrenrut @michaelDCurran |
|
@feerrenrut or @michaelDCurran Is this on your radar? This is requested for at least 8 years, and when someone finally has written the code for this the PR hasn't even been reviewed for 10 months. |
|
@JulienCochuyt Have you seen this commend by @jcsteh ? |
|
My code is not the optimal solution, and is not working for all screen
resolutions, but I have already make some changes to correct that...
For me, my code is only a fast answer to the problem while someone write
code to get the status bar retrieval by its object...
An add-on already have it for Explorer. NVDAExtensionGlobalPlugin ...
Rui Fontes
Às 17:35 de 28/04/2020, Łukasz Golonka escreveu:
…
@feerrenrut <https://github.com/feerrenrut> or @michaelDCurran
<https://github.com/michaelDCurran> Is this on your radar? This is
requested for at least 8 years, and when someone finally has written
the code for this the PR hasn't even been reviewed for 10 months.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#9792 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADZAPRQ7KSQVEGX6E5QPKETRO4AVLANCNFSM4H2YEJ4Q>.
|
|
@ruifontes Please note that status bar not being read on File Explorer is only one from countless examles for which being able to override status bar check would benefit. |
|
And regarding the addon, global extension global plugin is not an official addon, it has not passed the review because it is too comprehensive and there are many conflicts with NVDA's default features and key strokes. While I understand users who use it for certain cases, I would not see that addon as an alternative solution in the mid- or long-term. At least not for solving this problem. |
|
I do not mean to include the add-on in NVDA.
I was only saying that the code to retrieve the statusbar through the
respective object is already on the add-on...
Rui Fontes
Às 20:10 de 28/04/2020, Adriani90 escreveu:
…
And regarding the addon, global extension global plugin is not an
official addon, it has not passed the review because it is too
comprehensive and there are many conflicts with NVDA's default
features and key strokes. While I understand users who use it for
certain cases, I would not see that addon as an alternative solution
in the mid- or long-term. At least not for solving this problem.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9792 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADZAPRVGXVUEB2QHGA6MUBTRO4S2FANCNFSM4H2YEJ4Q>.
|
@JulienCochuyt This approach looks fine to me. Is there remaining work / testing necessary, or do you believe it is ready? |
|
@lukaszgo1 wrote:
Thanks for pointing this out:
I partly disagree. @feerrenrut wrote:
I believe it is ready as the code is fairly simple. |
feerrenrut
left a comment
There was a problem hiding this comment.
@JulienCochuyt Thanks for the update. I'm going to go ahead and merge this in that case.
|
Apparently this has broken NVDA's ability to report time-related info in Foobar2000 in Alpha 20080 -- see #11082 |
|
HI, traced to attribute name conflict (see #11087 for a pull request that resolves this). So far only Foobar2000 app module had an attribute named “statusBar”, but I would imagine ome add-on app modules might come with such an attribute, so I guess a community-wide advisory is necessary. Thanks.
|
|
Anyone interested in improving status bars or in Java applications, might also be interested in #5674 |
|
#11082 affecting Foobar2000 is fixed. |
Link to issue number:
Fixes #2125
Fixes #4640
Summary of the issue:
In some cases, the standard way to retrieve a status bar is not satisfying.
Description of how this pull request fixes the issue:
Add at AppModule level:
api.getStatusBarto retrieve a custom objectGlobalCommands.script_reportStatusLinewhen resorting to flat review.Another approach would have been to allow AppModule to override script_reportStatusLine altogether, but every implementation should then take care to provide the whole standard behavior of moving review and supporting copy to clipboard.
This PR is just a humble bare proposal, but please mind the first report on this issue dates back to 2012.
Testing performed:
Known issues with pull request:
Change log entry:
Section: Changes for Developers
Status bar retrieval may now be customized by an AppModule.