Python Console: Jump to previous/next result (#9784)#9785
Conversation
|
Added the control+L binding to clear the output and rebased onto latest master. |
|
990d28f: Rebased onto latest master |
|
Rebased onto latest master and linted. |
|
Working on another subject, I think I found a way to improve this PR: Take advantage of the fact the Python Console is a singleton to control it from the NVDA AppModule. |
I think this makes sense. |
|
@LeonarddeR: Just pushed the refactoring using the NVDA AppModule. |
|
@dingpengyu wrote:
From my side, everything is done. I'm using this feature on a daily basis through custom patching for about two years. |
|
well, if @michaelDCurran approved it, I don't think there's anything holding this back for a merge. May be it was missed somehow. |
|
It looks there have been a number of changes since Mick last reviewed. I'll request another review so he can look over the new changes. |
|
@JulienCochuyt Would you be able to resolve conflicts here? |
|
While at it, please also update the PR's initial descriptions:
|
|
This is great. |
|
@CyrilleB79 wrote:
Done. Sorry for the lengthy delay. |
feerrenrut
left a comment
There was a problem hiding this comment.
I've merged in master, and resolved conflicts. I'd like to understand this isPrevFocusOnNvdaPopup, but I'll need more ecplanation.
See test results for failed build of commit 8d767bd238 |
feerrenrut
left a comment
There was a problem hiding this comment.
Thanks @JulienCochuyt
|
Thanks @JulienCochuyt, I've been looking forward to this one for a long
time!
|
|
@feerrenrut, |
Link to issue number:
Fixes #9784
Summary of the issue:
In the output pane of the Python Console, it can be tedious to inspect a series of lengthy output results.
Description of how this pull request fixes the issue:
Provide key bindings to jump to the previous/next result, select a whole result and clear the output pane.
Testing performed:
Ported from an add-on in use for a few
months[EDIT] years.Known issues with pull request:
Change log entry:
Python Console: When the focus is on the output pane, alt+up/down jumps to the previous/next output result (add shift for selecting). control+l clears the output pane.