Add --copy-portable-config command line parameter to automatically copy the portable configuration with a silent installation#9679
Merged
michaelDCurran merged 9 commits intonvaccess:masterfrom Nov 16, 2020
BabbageCom:copyConfig
Merged
Add --copy-portable-config command line parameter to automatically copy the portable configuration with a silent installation#9679michaelDCurran merged 9 commits intonvaccess:masterfrom BabbageCom:copyConfig
michaelDCurran merged 9 commits intonvaccess:masterfrom
BabbageCom:copyConfig
Conversation
|
PR introduces Flake8 errors 😲 See test results for Failed build of commit 6f17a6bb1a |
Collaborator
Author
|
I wrote this pull request on behalf of @BabbageCom. As I'm leaving @BabbageCom after the 29th of November, I can no longer afford maintaining this pr other than applying very basic review actions. If this pull request requires major changes, they will have to be applied by someone else. |
Collaborator
Author
|
I just fixed the merge conflicts of this. I think it was pretty thoroughly tested. |
See test results for failed build of commit 744b79dd7d |
Contributor
|
Please note that this functionality has been requested once again in #11635. Since it has been well tested according to @LeonarddeR would it be possible to have this reviewed? cc @michaelDCurran @feerrenrut |
michaelDCurran
approved these changes
Nov 16, 2020
7 tasks
feerrenrut
added a commit
that referenced
this pull request
Apr 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #9676
Summary of the issue:
There is currently no automated way to install NVDA silently, thereby also copying a configuration profile folder to the user account. This is currently only possible when manually installing from a portable copy.
Description of how this pull request fixes the issue:
Added a new --copy-portable-config command line argument, which is stored as a boolean. If the core module initializes and discovers that copying the portable config is hazardous (particularly when running the currently installed config), this variable is set to None. This evaluates to False in most situations. IN the gui however, we explicitly check for None in order to disable the checkbox to enable this feature.
Note that commit 7eaf961 contains changes to the formatting of several huge lines in nvda.pyw. It has no functional changes.
Testing performed:
--copy-portable-config -c %appdata%\nvda, started the installation gui. Made sure that "copy the current user config" check box was disabled.--copy-portable-config -c somepath. Made sure that the checkbox was enabled and checked.--copy-portable-config --install. Made sure that the configuration was successfully kopied after the installation.Known issues with pull request:
There is no warning when --copy-portable-config is silently discarded for silent installations. I guess we really want to stay silent, and this will hardly happen.
Change log entry:
--copy-portable-configcommand line parameter that allows you to silently install NVDA and automatically copy the provided configuration to the user account. (Command line parameter to copy portable configuration on silent installations #9676)