Revert #8727 - built-ins, relative imports, importlib#9657
Merged
Conversation
Contributor
Author
|
Hi, Hmmm, when asking for a revert pull request on GitHub, it defaults to generating it from master. I'll forcefully replace this one with the one from beta branch. Thanks. |
b4d32c1 to
5252322
Compare
|
Lets hope that beta is not the e one I had issues installing on windows 7
this morning with a total crash. I had to reboot windows, though I git it to
run eventually by downloading it and not doing it as an update, but running
it and then making it overwrite the old portable. The logs are on the dev
list if anyone is interested. I have been out all day and I'm frazzled.
Brian
bglists@blueyonder.co.uk
Sent via blueyonder.
Please address personal E-mail to:-
briang1@blueyonder.co.uk, putting 'Brian Gaff'
in the display name field.
Newsgroup monitored: alt.comp.blind-users
----- Original Message -----
From: "Joseph Lee" <notifications@github.com>
To: "nvaccess/nvda" <nvda@noreply.github.com>
Cc: "Subscribed" <subscribed@noreply.github.com>
Sent: Friday, May 31, 2019 3:01 PM
Subject: Re: [nvaccess/nvda] Revert #8727 - built-ins, relative imports,
importlib (#9657)
… Hi,
Hmmm, when asking for a revert pull request on GitHub, it defaults to
generating it from master. I'll forcefully replace this one with the one
from beta branch.
Thanks.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#9657 (comment)
|
5252322 to
6269143
Compare
Contributor
Author
|
Hi, To @nishimotz, can you try the following build and see if it is resolved? |
Contributor
Contributor
Author
|
Hi, yep, this means importlib will be reserved for Threshold (I need to also add some more relative imports that were missed in the initial run). Thanks. CC @LeonarddeR for comments please.
From: Takuya Nishimoto <notifications@github.com>
Sent: Friday, May 31, 2019 5:12 PM
To: nvaccess/nvda <nvda@noreply.github.com>
Cc: Joseph Lee <joseph.lee22590@gmail.com>; Mention <mention@noreply.github.com>
Subject: Re: [nvaccess/nvda] Revert #8727 - built-ins, relative imports, importlib (#9657)
@josephsl <https://github.com/josephsl> issue #9583 <#9583> does not occur with nvda_snapshot_pr9657-17432,35710fab.exe.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#9657?email_source=notifications&email_token=AB4AXEFZLMZYJGXCKYQOUOTPYG5ENA5CNFSM4HR25BX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWWUMIQ#issuecomment-497894946> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AB4AXEC7FDITZ5B4ZZJ4MRTPYG5ENANCNFSM4HR25BXQ> .
|
michaelDCurran
approved these changes
Jun 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Various regressions from #8727.
Summary of the issue:
Regressions such as inability to correctly load app modules for multibyte file names were observed.
Description of how this pull request fixes the issue:
There are several pull requests meant to resolve regressions, but it was decided to revert changes and reserve them for Threshold/Python 3.
Testing performed:
TBD (to be done via try builds).
Known issues with pull request:
None so far.
Change log entry:
None