txt2tags for python3 #8734#9648
Merged
michaelDCurran merged 6 commits intonvaccess:threshold_py3_stagingfrom Jun 11, 2019
Merged
txt2tags for python3 #8734#9648michaelDCurran merged 6 commits intonvaccess:threshold_py3_stagingfrom
michaelDCurran merged 6 commits intonvaccess:threshold_py3_stagingfrom
Conversation
Contributor
|
Hi,
I am against putting the changelog item for this into the new features section, at it is a developers change not visible for the end-user.
From: Takuya Nishimoto <notifications@github.com>
Sent: Friday, May 31, 2019 12:15 PM
To: nvaccess/nvda <nvda@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Subject: [nvaccess/nvda] txt2tags for python3 #8734 (#9648)
Link to issue number:
#8734 <#8734>
Summary of the issue:
This PR is against the threshold branch.
It replaces txt2tags.py and keyCommandDoc.py with my work of https://github.com/nvdajp/txt2tags.
Note that nvda-misc-deps is forked and https://github.com/nvdajp/nvda-misc-deps is used.
Description of how this pull request fixes the issue:
Part of this repository is verified that it can make the same documents using Python 3.7.3.
Testing performed:
This repository itself is not tested.
Known issues with pull request:
Change log entry:
Section: New features, Changes, Bug fixes
…_____
You can view, comment on, or merge this pull request online at:
#9648
Commit Summary
* txt2tags for python3 #8734
File Changes
* M .gitmodules <https://github.com/nvaccess/nvda/pull/9648/files#diff-0> (2)
* M keyCommandsDoc.py <https://github.com/nvaccess/nvda/pull/9648/files#diff-1> (15)
* M miscDeps <https://github.com/nvaccess/nvda/pull/9648/files#diff-2> (2)
Patch Links:
* https://github.com/nvaccess/nvda/pull/9648.patch
* https://github.com/nvaccess/nvda/pull/9648.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#9648?email_source=notifications&email_token=ACVCDE76TRDRUTBGEQBKKM3PYD3AVA5CNFSM4HRXXVV2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GW5QBAQ> , or mute the thread <https://github.com/notifications/unsubscribe-auth/ACVCDE34Y3GCJRUO2SFUWJTPYD3AVANCNFSM4HRXXVVQ> .
|
LeonarddeR
suggested changes
May 31, 2019
Collaborator
LeonarddeR
left a comment
There was a problem hiding this comment.
- Could you also process site_scons/site_tools/t2t.py
- It would be good to know what you did to get this result. Was it simply running the code through 2to3?
- I assume you're still planning to file a pr against nvda-misc-deps for txt2tags itself?
Co-Authored-By: Leonard de Ruijter <leonardder@users.noreply.github.com>
LeonarddeR
approved these changes
Jun 10, 2019
Collaborator
|
@michaelDCurran: as soon as nvaccess/nvda-misc-deps#12 is merged, this needs an update of misc-deps to master. |
michaelDCurran
approved these changes
Jun 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
#8734
Summary of the issue:
This PR is against the threshold branch.
It replaces txt2tags.py and keyCommandDoc.py with my work of https://github.com/nvdajp/txt2tags.
Note that nvda-misc-deps is forked and https://github.com/nvdajp/nvda-misc-deps is used.
Description of how this pull request fixes the issue:
Part of this repository is verified that it can make the same documents using Python 3.7.3.
Testing performed:
This repository itself is not tested.
Known issues with pull request:
Change log entry:
Section: New features, Changes, Bug fixes