Remove functionality marked as deprecated#9603
Merged
Merged
Conversation
Contributor
|
This PR has the following error during the build |
added 10 commits
May 22, 2019 08:10
Collaborator
Author
|
If this fails again, it will be fixed as soon as master is merged into threshold again. Having said that, I'd like to kindly ask you to please refrain from reporting every single failure for a pr, unless you think it is an urgent failure. If pull requests are acted upon, usually the first thing done is fixing these failures or conflicts. |
|
Hi Leonardder, |
Contributor
|
No, still many people using Office 2007 because it is the last one with
menus...
Rui Fontes
Às 23:42 de 26/05/2019, enessaribas escreveu:
… Hi Leonardder,
Could we also consider removing support for applications which are long
past official support from the developer, wsuch as office xp/2003/2007?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#9603?email_source=notifications&email_token=ADZAPRSZSADJCAMBYRPJNLLPXMG4LA5CNFSM4HONC4DKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWIO3CA#issuecomment-496037256>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADZAPRRQZJURZLT42OR4H6TPXMG4LANCNFSM4HONC4DA>.
|
Contributor
|
Hi, actually, the last one with all menus is 2003, as 2007 introduced ribbons. I think that should not be the reason to block removals, although we may need to think carefully about pros and cons. Thanks.
From: ruifontes <notifications@github.com>
Sent: Sunday, May 26, 2019 3:53 PM
To: nvaccess/nvda <nvda@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Subject: Re: [nvaccess/nvda] Remove functionality marked as deprecated (#9603)
No, still many people using Office 2007 because it is the last one with
menus...
Rui Fontes
Às 23:42 de 26/05/2019, enessaribas escreveu:
Hi Leonardder,
Could we also consider removing support for applications which are long
past official support from the developer, wsuch as office xp/2003/2007?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#9603?email_source=notifications&email_token=ADZAPRSZSADJCAMBYRPJNLLPXMG4LA5CNFSM4HONC4DKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWIO3CA#issuecomment-496037256>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADZAPRRQZJURZLT42OR4H6TPXMG4LANCNFSM4HONC4DA>.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#9603?email_source=notifications&email_token=AB4AXEDAQV653V2MAU6QVATPXMIENA5CNFSM4HONC4DKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWIO7TI#issuecomment-496037837> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AB4AXEDHUXEBCYND6J62L7TPXMIENANCNFSM4HONC4DA> .
|
Collaborator
Author
|
Hmm, this request makes sense, however, it also increases the number of
things that need to be tested. We have to consider this carefully.
|
|
Hi Leonardder, |
Collaborator
Author
|
We actually removed support for Skype 7 around a month ago, but we got
urgent requests to restore this. It seems like there is still a Russian
patched version of Skype 7 around somewhere.
|
Contributor
|
hi.
it is not working anymore.
…On 5/27/19, Leonard de Ruijter ***@***.***> wrote:
We actually removed support for Skype 7 around a month ago, but we got
urgent requests to restore this. It seems like there is still a Russian
patched version of Skype 7 around somewhere.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#9603 (comment)
--
with best regards beqa
|
Contributor
|
Yes, I can confirm it.
From: beqa gozalishvili <notifications@github.com>
Sent: Monday, May 27, 2019 12:59 PM
To: nvaccess/nvda <nvda@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Subject: Re: [nvaccess/nvda] Remove functionality marked as deprecated (#9603)
hi.
it is not working anymore.
…On 5/27/19, Leonard de Ruijter ***@***.*** ***@***.***> > wrote:
We actually removed support for Skype 7 around a month ago, but we got
urgent requests to restore this. It seems like there is still a Russian
patched version of Skype 7 around somewhere.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#9603 (comment)
--
with best regards beqa
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#9603?email_source=notifications&email_token=ACVCDE3UQ3F7WB4A2UDQIPTPXO5F7A5CNFSM4HONC4DKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWJP6KQ#issuecomment-496172842> , or mute the thread <https://github.com/notifications/unsubscribe-auth/ACVCDE4O22XTQNUWG6CKIY3PXO5F7ANCNFSM4HONC4DA> . <https://github.com/notifications/beacon/ACVCDE2GVRPABNOHH3JLOUTPXO5F7A5CNFSM4HONC4DKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWJP6KQ.gif>
|
Contributor
|
Hi, although client version is out of support, Windows Server 2012 is still being used within organizations to some degree. Note that dropping support for Windows 8 means creating a gap in UIA support, as Windows 8 introduces UIA2 and UIA3 came with 8.1. Thanks.
From: enessaribas <notifications@github.com>
Sent: Monday, May 27, 2019 3:02 AM
To: nvaccess/nvda <nvda@noreply.github.com>
Cc: Joseph Lee <joseph.lee22590@gmail.com>; Comment <comment@noreply.github.com>
Subject: Re: [nvaccess/nvda] Remove functionality marked as deprecated (#9603)
Hi Leonardder,
You might as well remove the skype7 app module, as it isn't usable when a user signs out. Also it is highly unstable with messages not arriving and requests not being displayed so users shouldn't be using it anyway at this point.
Additionally, does supporting windows 8, also end of life since January 2016, require different code from 8.1 and 10?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <#9603?email_source=notifications&email_token=AB4AXEAEZGLXSWW3IDBKVJTPXOWSNA5CNFSM4HONC4DKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWJMHBI#issuecomment-496157573> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AB4AXEFW5XXMD6KK6IDKV3LPXOWSNANCNFSM4HONC4DA> .
|
| # earlier versions of NVDA. Its presence causes problems in Windows Vista. | ||
| fn = os.path.join(destPath, "mpr.dll") | ||
| if os.path.isfile(fn): | ||
| tryRemoveFile(fn) |
Member
There was a problem hiding this comment.
Do you have evidence that not removing this file does not affect Windows 7 and up? True the comment said Windows Vista, but that is no doubt only because the comment was put there in the Windows Vista timeframe.
Member
There was a problem hiding this comment.
If you're not sure, please revert this particular change.
Collaborator
Author
There was a problem hiding this comment.
I decided to remove the change as you suggested. Indeed, I'm not 100% sure, and better safe than sorry.
added 6 commits
May 29, 2019 06:55
This reverts commit dfb2dbc.
…ring on SynthDriver, as it is already part of the Driver class
Collaborator
Author
|
@michaelDCurran: I believe this is now ready. |
michaelDCurran
approved these changes
May 29, 2019
5 tasks
seanbudd
pushed a commit
that referenced
this pull request
Oct 19, 2021
This PR removes the following: - sysTreeView32 contains unused `TVItemStruct` - no idea what for (this code was there and was unused since 97a2fc6 so for as long as this module). - `MessageItem` class from the app Module for Outlook (last usages removed in #9603) - `getPath` from the poedit appModule - this function was not used anywhere and in addition was broken (it references nonexistent variable `stopObj`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #9548
Summary of the issue:
NVDA contains several functions and classes that are marked deprecated.speech ref
Description of how this pull request fixes the issue:
This Pr removes all code that is marked deprecated. This includes:
from configobj import validateinstead ofimport validatesynthDriverHandler.SynthDriver.speakText/speakCharacter, survived speech refactor and have been removed
Testing performed:
Known issues with pull request:
None
Change log entry:
Some of the deprecated classes and functions might have to be listed in the changes for developers section, particularly for synthesizer drivers and textInfos. I think the listing above can be a godo starting point for that.