Added C# example for NVDA controller client DLL#9600
Merged
Conversation
feerrenrut
suggested changes
May 21, 2019
feerrenrut
left a comment
Contributor
There was a problem hiding this comment.
Thanks for taking this on.
It looks like the file is included twice. Please delete the example.cs one, the other comments for that file also apply to the example_csharp.cs file
| /// <param name="interrupt">If true, NVDA will immediately speak the text, interrupting whatever it was speaking before.</param> | ||
| public static void Speak(string text, bool interrupt = true) | ||
| { | ||
| if (interrupt) |
Contributor
There was a problem hiding this comment.
While it is certainly valid to leave the braces out, it's not recommended. It is very easy for someone to add a second line to this which will not be subject to the condition.
Contributor
Author
|
Sorry, but it is so common in the .NET world to adopt this coding style. |
Contributor
|
No problem, I understand the temptation. I have just seen too much wasted time because of it. Thanks for making the changes. |
feerrenrut
approved these changes
May 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Based on #7010.
Summary of the issue:
The original author of #7010 seems not to be active anymore, even if there are still review actions to perform on the PR.
Description of how this pull request fixes the issue:
This PR introduces a C# program containing a PInvoke wrapper around nvdaControllerClient.dll, and demonstrates how to use it.
I also updated the readme. I think that the link pointing to the pre-built binaries should be updated as well.
Testing performed:
Performed the same tasks as in the Python example.
Known issues with pull request:
None.
Change log entry:
Section: New features